Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9187066: Merge 104782 - Repaint all graphics layers when their renderer offset changes (Closed)

Created:
8 years, 11 months ago by enne (OOO)
Modified:
8 years, 11 months ago
Reviewers:
enne_
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 104782 - Repaint all graphics layers when their renderer offset changes https://bugs.webkit.org/show_bug.cgi?id=75730 Reviewed by Simon Fraser. Source/WebCore: In RenderLayerBacking, only the main graphics layer gets repainted when the offset changes. If the offset on other graphics layers (e.g. the foreground layer) changes, they should get repainted as well. Test: compositing/geometry/foreground-offset-change.html * platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::paintGraphicsLayerContents): * platform/graphics/GraphicsLayer.h: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::paintContents): LayoutTests: * compositing/geometry/foreground-offset-change-expected.png: Added. * compositing/geometry/foreground-offset-change-expected.txt: Added. * compositing/geometry/foreground-offset-change.html: Added. TBR=enne@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
A + LayoutTests/compositing/geometry/foreground-offset-change.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/geometry/foreground-offset-change-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/geometry/foreground-offset-change-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/GraphicsLayer.cpp View 3 chunks +22 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerBacking.cpp View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
enne (OOO)
8 years, 11 months ago (2012-01-12 21:34:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698