Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 9187062: Restart the Android emulator for each test. (Closed)

Created:
8 years, 11 months ago by John Grabowski
Modified:
8 years, 11 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, Peter Beverloo
Visibility:
Public.

Description

Restart the Android emulator for each test. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117508

Patch Set 1 #

Total comments: 4

Patch Set 2 : caps issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -28 lines) Patch
M build/android/run_tests.py View 1 8 chunks +61 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
John Grabowski
The emulator likes to kill itself anyway... minus well help it along. Seems to make ...
8 years, 11 months ago (2012-01-12 20:12:07 UTC) #1
michaelbai
lgtm http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py#newcode176 build/android/run_tests.py:176: fully_qualified_test_suites = FUllyQualifiedTestSuites() FUlly? http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py#newcode253 build/android/run_tests.py:253: """Dispatches the ...
8 years, 11 months ago (2012-01-12 21:19:45 UTC) #2
John Grabowski
8 years, 11 months ago (2012-01-12 21:34:34 UTC) #3
Thanks Michael.

http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py#newc...
build/android/run_tests.py:176: fully_qualified_test_suites =
FUllyQualifiedTestSuites()
On 2012/01/12 21:19:45, michaelbai wrote:
> FUlly?

oops good catch

http://codereview.chromium.org/9187062/diff/1/build/android/run_tests.py#newc...
build/android/run_tests.py:253: """Dispatches the tests, sharding if possible.
On 2012/01/12 21:19:45, michaelbai wrote:
> Do we really support 'sharding'?

In theory yes; the test code was brought into Chromium after sharding was added.
 But in Chromium we only run tests on an emulator (so far) so it is not
meaningful to shard across "devices".

Powered by Google App Engine
This is Rietveld 408576698