Transition to base/mac/bundle_locations.h step 1

Transition to base/mac/bundle_locations.h step 1

Initial transition steps, trying to do this in small steps so it's easier to review.

foundation_util.h:
* Remove SetOverride*() methods and modify all callsites to use bundle_location.h version.
* MainAppBundle() - call through to bundle_location version as an interim step.
* Rename PathForFrameworkBundleResource() and modify callers.
* Remove one instance of [NSBundle mainBundle].
BUG=None
TEST=Chrome/Mac should launch correctly and all unit tests should pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118284

[Avi (use Gerrit), 2012-01-12 15:29:44]

http://codereview.chromium.org/9187053/diff/2001/base/mac/foundation_util.mm
File base/mac/foundation_util.mm (right):

http://codereview.chromium.org/9187053/diff/2001/base/mac/foundation_util.mm#...
base/mac/foundation_util.mm:72: return base::mac::FrameworkBundle();
If this is a call-through, and the bundle_locations.h function names are
clearer, we ought to remove MainAppBundle and MainAppBundlePath and move callers
to use FrameworkBundle() and FrameworkBundlePath() instead.

[Avi (use Gerrit), 2012-01-12 15:30:41]

Oh. "step 1". My mistake, should read closer. LGTM

[Mark Mentovai, 2012-01-12 15:33:19]

LGTM

http://codereview.chromium.org/9187053/diff/2001/base/i18n/icu_util.cc
File base/i18n/icu_util.cc (right):

http://codereview.chromium.org/9187053/diff/2001/base/i18n/icu_util.cc#newcod...
base/i18n/icu_util.cc:112: // Assume it is in the Framework Bundle's Resources
directory.
Framework bundle is not a proper name. Use lowercase letters.

http://codereview.chromium.org/9187053/diff/2001/base/mac/foundation_util.h
File base/mac/foundation_util.h (right):

http://codereview.chromium.org/9187053/diff/2001/base/mac/foundation_util.h#n...
base/mac/foundation_util.h:52: // Returns the path to a resource within the
Framework bundle.
Again.

[commit-bot: I haz the power, 2012-01-15 14:41:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/9187053/8001

[commit-bot: I haz the power, 2012-01-15 14:41:42]

Presubmit check for 9187053-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/gfx/test_suite.cc,webkit/tools/test_shell/run_all_tests.cc

Presubmit checks took 2.6s to calculate.

[jeremy, 2012-01-15 14:43:02]

Ben/Sky: I need an owner LGTM from one of you for the changes to
ui/gfx/test_suite.cc,webkit/tools/test_shell/run_all_tests.cc - thanks!

[sky, 2012-01-17 16:03:40]

ui/gfx/test_suite.cc LGTM
I'm not an owner of webkit.

[jeremy, 2012-01-17 19:18:56]

Tony: Could I get an owner review for the file in webkit/ - rubberstamp ok.

[tony, 2012-01-18 20:09:03]

LGTM

[commit-bot: I haz the power, 2012-01-19 08:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/9187053/8001

[commit-bot: I haz the power, 2012-01-19 10:56:01]

Change committed as 118284