Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 9187027: Attempt 2 at: Adds a trivial views based table implementation (only supports single (Closed)

Created:
8 years, 11 months ago by sky
Modified:
8 years, 11 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Attempt 2 at: Adds a trivial views based table implementation (only supports single selection, even for grouptableview) and wires it up for hung renderer and ssl client certificate. Only change is adding OVERRIDEs. BUG=109665 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+465 lines, -495 lines) Patch
M chrome/browser/ui/views/hung_renderer_view.cc View 7 chunks +31 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/hung_renderer_dialog.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ssl_client_certificate_selector_webui.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/views/controls/table/group_table_view.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/table/group_table_view_views.h View 3 chunks +3 lines, -42 lines 0 comments Download
A ui/views/controls/table/group_table_view_views.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/table/table_view_unittest.cc View 4 chunks +1 line, -8 lines 0 comments Download
M ui/views/controls/table/table_view_views.h View 6 chunks +34 lines, -384 lines 0 comments Download
A ui/views/controls/table/table_view_views.cc View 1 chunk +287 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/table/table_view_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/examples/examples_window.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M ui/views/examples/table_example.cc View 6 chunks +21 lines, -8 lines 0 comments Download
M ui/views/views.gyp View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 11 months ago (2012-01-11 22:20:23 UTC) #1
Ben Goodger (Google)
8 years, 11 months ago (2012-01-11 22:20:48 UTC) #2
LGTM

On Wed, Jan 11, 2012 at 2:20 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Attempt 2 at: Adds a trivial views based table implementation (only
> supports
> single
> selection, even for grouptableview) and wires it up for hung renderer
> and ssl client certificate.
>
> Only change is adding OVERRIDEs.
>
> BUG=109665
> TEST=none
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/9187027/<http://codereview.chromium.org/9187...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/views/hung_**renderer_view.cc
>  M chrome/browser/ui/views/ssl_**client_certificate_selector.cc
>  M chrome/browser/ui/webui/hung_**renderer_dialog.cc
>  M chrome/browser/ui/webui/ssl_**client_certificate_selector_**webui.cc
>  M chrome/chrome_browser.gypi
>  M ui/views/controls/table/group_**table_view.h
>  M ui/views/controls/table/group_**table_view_views.h
>  A ui/views/controls/table/group_**table_view_views.cc
>  M ui/views/controls/table/table_**view.h
>  M ui/views/controls/table/table_**view_unittest.cc
>  M ui/views/controls/table/table_**view_views.h
>  A ui/views/controls/table/table_**view_views.cc
>  M ui/views/controls/table/table_**view_win.h
>  M ui/views/controls/table/table_**view_win.cc
>  M ui/views/examples/examples_**window.cc
>  M ui/views/examples/table_**example.cc
>  M ui/views/views.gyp
>
>
>

Powered by Google App Engine
This is Rietveld 408576698