Issue 9187023: Convert use of int ms to TimeDelta in files owned by ajwong.

Issue 9187023: Convert use of int ms to TimeDelta in files owned by ajwong. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes

Modified:
8 years, 11 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Convert use of int ms to TimeDelta in files owned by ajwong. R=ajwong@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117531

Patch Set 1 #

Patch Set 2 : Remove static class initializations. #

Patch Set 3 : Remove static class instance initialization. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
M	chrome/service/cloud_print/cloud_print_auth.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View	1	10 chunks	+14 lines, -13 lines	0 comments	Download
M	chrome/service/service_process.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	jingle/glue/thread_wrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9187023/1

8 years, 11 months ago (2012-01-11 22:14:32 UTC) #3

commit-bot: I haz the power

Try job failure for 9187023-1 (retry) on mac_rel for step "ui_tests". It's a second try, ...

8 years, 11 months ago (2012-01-12 00:25:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9187023/1

8 years, 11 months ago (2012-01-12 20:43:14 UTC) #5

Ted Vessenes

8 years, 11 months ago (2012-01-15 21:31:21 UTC) #7

On 2012/01/12 22:20:49, I haz the power (commit-bot) wrote:
> Change committed as 117531

So this change was apparently reverted, since there was a static class instance
initialization which broke the build.  I've corrected this and would like to
reapply it, but the commit checkbox is greyed out (presumably because the system
thinks the patch is already in place.)  How should we handle this?

Expand Messages | Collapse Messages