Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 9187018: Mark CrashEscHandlers flaky. (Closed)

Created:
8 years, 11 months ago by flackr
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Mark FindInPageTest.CrashEscHandlers flaky. BUG=109906 TEST=interactive_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117282

Patch Set 1 #

Patch Set 2 : Only flaky with use_aura. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
flackr
Happened a couple times recently: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/2251 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/2249
8 years, 11 months ago (2012-01-11 20:46:36 UTC) #1
Ben Goodger (Google)
8 years, 11 months ago (2012-01-11 20:57:06 UTC) #2
LGTM

On Wed, Jan 11, 2012 at 12:46 PM, <flackr@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Happened a couple times recently:
>
> http://build.chromium.org/p/**chromium.chromiumos/builders/**
>
Linux%20ChromeOS%20Aura/**builds/2251<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/2251>
>
> http://build.chromium.org/p/**chromium.chromiumos/builders/**
>
Linux%20ChromeOS%20Aura/**builds/2249<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS%20Aura/builds/2249>
>
> Description:
> Mark FindInPageTest.**CrashEscHandlers flaky.
>
> TBR=ben
>
> BUG=109906
> TEST=interactive_ui_tests
>
> Please review this at
http://codereview.chromium.**org/9187018/<http://codereview.chromium.org/9187...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/views/find_**bar_host_interactive_uitest.cc
>
>
> Index: chrome/browser/ui/views/find_**bar_host_interactive_uitest.cc
> diff --git a/chrome/browser/ui/views/**find_bar_host_interactive_**uitest.cc
> b/chrome/browser/ui/views/**find_bar_host_interactive_**uitest.cc
> index 1829fedfe5275db52444e8d9487f8a**e3288d76da..**
> 14e63f13b5365ffdffa03de209d0a3**b68e28a641 100644
> --- a/chrome/browser/ui/views/**find_bar_host_interactive_**uitest.cc
> +++ b/chrome/browser/ui/views/**find_bar_host_interactive_**uitest.cc
> @@ -71,13 +71,8 @@ class FindInPageTest : public InProcessBrowserTest {
>
>  }  // namespace
>
> -#if defined(TOOLKIT_USES_GTK)
> -#define MAYBE_CrashEscHandlers FLAKY_CrashEscHandlers
> -#else
> -#define MAYBE_CrashEscHandlers CrashEscHandlers
> -#endif
> -
> -IN_PROC_BROWSER_TEST_F(**FindInPageTest, MAYBE_CrashEscHandlers) {
> +// Flaky (See crbug.com/109906).
> +IN_PROC_BROWSER_TEST_F(**FindInPageTest, FLAKY_CrashEscHandlers) {
>   ASSERT_TRUE(test_server()->**Start());
>
>   // First we navigate to our test page (tab A).
>
>
>

Powered by Google App Engine
This is Rietveld 408576698