Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Unified Diff: chrome/browser/net/connection_tester_unittest.cc

Issue 9187017: Don't pump the message loop in DeleteWhileInProgress at all. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't include windows.h and reword the comment Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/connection_tester_unittest.cc
diff --git a/chrome/browser/net/connection_tester_unittest.cc b/chrome/browser/net/connection_tester_unittest.cc
index cbdf156dcc09c2f5dc29f82ba4c4d258b4e6ed0b..961be6fba1969a5776edfe780fe76d1ce32c7ec8 100644
--- a/chrome/browser/net/connection_tester_unittest.cc
+++ b/chrome/browser/net/connection_tester_unittest.cc
@@ -176,7 +176,9 @@ TEST_F(ConnectionTesterTest, DeleteWhileInProgress) {
// TODO(eroman): Is this URL right?
tester->RunAllTests(test_server_.GetURL("echoall"));
- MessageLoop::current()->RunAllPending();
+ // Don't run the message loop at all. Otherwise the experiment's request may
+ // complete and post a task to run the next experiment before we quit the
+ // message loop.
EXPECT_EQ(1, test_delegate_.start_connection_test_suite_count());
EXPECT_EQ(1, test_delegate_.start_connection_test_experiment_count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698