Issue 9187017: Don't pump the message loop in DeleteWhileInProgress at all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9187017: Don't pump the message loop in DeleteWhileInProgress at all. (Closed)

Created:
8 years, 11 months ago by Reid Kleckner

Modified:
8 years, 11 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't pump the message loop in DeleteWhileInProgress at all. This avoids a race condition where the request completes before the message loop finishes its pending tasks. The posted task starts the next experiment, and so the assertion that only 1 experiment should be started fails. R=eroman@chromium.org BUG=88221 TEST=ConnectionTesterTest.DeleteWhileInProgress under drmemory Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117314

Patch Set 1 #

Patch Set 2 : Don't include windows.h and reword the comment #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/net/connection_tester_unittest.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/9187017/2001

8 years, 11 months ago (2012-01-11 21:13:09 UTC) #3

Change committed as 117314

Expand Messages | Collapse Messages