Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/browser/chrome_browser_main.h

Issue 9187011: Set up the field trials before IOThread creation. We can't wait until after all the threads are c... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.h
===================================================================
--- chrome/browser/chrome_browser_main.h (revision 117220)
+++ chrome/browser/chrome_browser_main.h (working copy)
@@ -88,7 +88,6 @@
}
Profile* profile() { return profile_; }
- MetricsService* metrics() { return metrics_; }
private:
// Methods for |EarlyInitialization()| ---------------------------------------
@@ -129,16 +128,16 @@
// Constructs metrics service and does related initialization, including
// creation of field trials. Call only after labs have been converted to
// switches.
- MetricsService* SetupMetricsAndFieldTrials(PrefService* local_state);
+ void SetupMetricsAndFieldTrials();
- static MetricsService* InitializeMetrics(
- const CommandLine& parsed_command_line,
- const PrefService* local_state);
-
// Add an invocation of your field trial init function to this method.
void SetupFieldTrials(bool metrics_recording_enabled,
bool proxy_policy_is_set);
+ // Starts recording of metrics. This can only be called after we have a file
+ // thread.
+ void StartMetricsRecording();
+
// Methods for Main Message Loop -------------------------------------------
int PreCreateThreadsImpl();
@@ -193,7 +192,6 @@
// PreMainMessageLoopRunThreadsCreated.
bool is_first_run_;
bool first_run_ui_bypass_;
- MetricsService* metrics_;
PrefService* local_state_;
FilePath user_data_dir_;
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698