Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9187006: Small fixes to hash seeding code, discovered during (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Small fixes to hash seeding code, discovered during review of back port. Committed: http://code.google.com/p/v8/source/detail?r=10397

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/ia32/macro-assembler-ia32.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-11 13:52:32 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1007 src/ia32/macro-assembler-ia32.cc:1007: times_pointer_size, untagging can go into addressing mode.
8 years, 11 months ago (2012-01-11 13:55:09 UTC) #2
Erik Corry
http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1007 src/ia32/macro-assembler-ia32.cc:1007: times_pointer_size, On 2012/01/11 13:55:10, Vyacheslav Egorov wrote: > untagging ...
8 years, 11 months ago (2012-01-12 08:13:29 UTC) #3
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-13 07:55:48 UTC) #4
lgtm

yeah that was stupid of me.

Powered by Google App Engine
This is Rietveld 408576698