Issue 9187006: Small fixes to hash seeding code, discovered during

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9187006: Small fixes to hash seeding code, discovered during (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Small fixes to hash seeding code, discovered during review of back port. Committed: http://code.google.com/p/v8/source/detail?r=10397

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	src/ia32/macro-assembler-ia32.cc	View	1 2	3 chunks	+6 lines, -5 lines	0 comments	Download
	M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1007 src/ia32/macro-assembler-ia32.cc:1007: times_pointer_size, untagging can go into addressing mode.

8 years, 11 months ago (2012-01-11 13:55:09 UTC) #2

Erik Corry

http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9187006/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1007 src/ia32/macro-assembler-ia32.cc:1007: times_pointer_size, On 2012/01/11 13:55:10, Vyacheslav Egorov wrote: > untagging ...

8 years, 11 months ago (2012-01-12 08:13:29 UTC) #3

lgtm

yeah that was stupid of me.

Expand Messages | Collapse Messages

Issue 9187006: Small fixes to hash seeding code, discovered during (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages