Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9187003: Merge r10380, r10381 from the bleeding_edge to the 3.7 branch. (Closed)

Created:
8 years, 11 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merge r10380, r10381 from the bleeding_edge to the 3.7 branch. Change inlined cache of intanceof stub to use indirection through cell. The stub was directly patching caller's code without issuing write barrier which violated incremental marking invariants. R=mstarzinger@chromium.org BUG=http://crbug.com/109448 TEST=cctest/test-heap/InstanceOfStubWriteBarrier Review URL: http://codereview.chromium.org/9158015 ------------------------------------------------------------------------ Fix build failure introduced by r10380 TBR=mstarzinger@chromium.org Review URL: http://codereview.chromium.org/9190002 ------------------------------------------------------------------------ Committed: http://code.google.com/p/v8/source/detail?r=10387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -18 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/incremental-marking.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-11 10:28:42 UTC) #1
Michael Starzinger
8 years, 11 months ago (2012-01-11 10:29:47 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698