Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 9186053: Linux: stop migrating old, shared passwords into the profile-specific password scheme. (Closed)

Created:
8 years, 11 months ago by Mike Mammarella
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, anna
Visibility:
Public.

Description

Linux: stop migrating old, shared passwords into the profile-specific password scheme. It's been long enough that any passwords that are going to get migrated should be. This will help avoid a number of issues with keyrings that grow in size over time due to repeated testing, but it won't do anything to fix the existing huge keyrings with many abandoned entries. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117730

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Mammarella
8 years, 11 months ago (2012-01-12 23:21:02 UTC) #1
Evan Martin
lgtm
8 years, 11 months ago (2012-01-12 23:32:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/9186053/1
8 years, 11 months ago (2012-01-12 23:40:44 UTC) #3
commit-bot: I haz the power
Try job failure for 9186053-1 (retry) on linux_rel for step "unit_tests". It's a second try, ...
8 years, 11 months ago (2012-01-13 00:39:19 UTC) #4
Mike Mammarella
Whoops, forgot I wrote tests for this. :)
8 years, 11 months ago (2012-01-13 21:32:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdm@chromium.org/9186053/7001
8 years, 11 months ago (2012-01-13 21:33:06 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-13 23:56:35 UTC) #7
Change committed as 117730

Powered by Google App Engine
This is Rietveld 408576698