Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1797)

Unified Diff: content/common/content_paths.cc

Issue 9186033: Swap fallback order to search LayoutTests directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/content_paths.cc
diff --git a/content/common/content_paths.cc b/content/common/content_paths.cc
index 6f828b858dd24c62c68b598dd5fae86e6502d3b3..19232b2fbca2cc65cf81957a468a55044888e5a5 100644
--- a/content/common/content_paths.cc
+++ b/content/common/content_paths.cc
@@ -39,18 +39,18 @@ bool PathProvider(int key, FilePath* result) {
}
case DIR_LAYOUT_TESTS: {
FilePath cur;
- if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
+ if (!PathService::Get(DIR_TEST_DATA, &cur))
return false;
- cur = cur.Append(FILE_PATH_LITERAL("third_party"));
- cur = cur.Append(FILE_PATH_LITERAL("WebKit"));
+ cur = cur.Append(FILE_PATH_LITERAL("layout_tests"));
cur = cur.Append(FILE_PATH_LITERAL("LayoutTests"));
M-A Ruel 2012/06/20 19:42:59 It's been 2 months and content/test/data/layout_te
jabdelmalek 2012/06/20 19:55:34 It would be nice to check these into content/test/
if (file_util::DirectoryExists(cur)) {
*result = cur;
return true;
}
- if (!PathService::Get(DIR_TEST_DATA, &cur))
+ if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))
return false;
- cur = cur.Append(FILE_PATH_LITERAL("layout_tests"));
+ cur = cur.Append(FILE_PATH_LITERAL("third_party"));
+ cur = cur.Append(FILE_PATH_LITERAL("WebKit"));
cur = cur.Append(FILE_PATH_LITERAL("LayoutTests"));
*result = cur;
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698