Remove VideoDecodeAccelerator::Client::NotifyEndOfStream / PPP_VideoDecoder_Dev::EndOfStream

Remove VideoDecodeAccelerator::Client::NotifyEndOfStream / PPP_VideoDecoder_Dev::EndOfStream
Nobody's ever called it and it doesn't make sense given the API: EOS is
signalled when no more bits are available to Decode(), via Flush().

BUG=109819
TEST=trybots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117545

[Ami GONE FROM CHROMIUM, 2012-01-11 23:45:24]

Antoine: please review everything.
John: please OWNERS-review for content/common.

Thanks!

[Ami GONE FROM CHROMIUM, 2012-01-11 23:50:04]

http://codereview.chromium.org/9186022/diff/23/ppapi/cpp/dev/video_decoder_cl...
File ppapi/cpp/dev/video_decoder_client_dev.h (left):

http://codereview.chromium.org/9186022/diff/23/ppapi/cpp/dev/video_decoder_cl...
ppapi/cpp/dev/video_decoder_client_dev.h:41: virtual void
EndOfStream(PP_Resource decoder) = 0;
piman: is this legit to do?  IOW does the cpp/ version of the c/ interface
always track the latest API, or what?

[jam, 2012-01-12 05:20:00]

I'm not familiar with content/common/gpu, so i don't feel qualified to review it

[Ami GONE FROM CHROMIUM, 2012-01-12 17:39:11]

kbr: please OWNERS-review content/common/gpu.  Thanks.

[piman, 2012-01-12 19:44:06]

cc:ihf,rbultje this will need a ppapi update in flash for accelerated video
decode.

http://codereview.chromium.org/9186022/diff/23/ppapi/cpp/dev/video_decoder_cl...
File ppapi/cpp/dev/video_decoder_client_dev.h (left):

http://codereview.chromium.org/9186022/diff/23/ppapi/cpp/dev/video_decoder_cl...
ppapi/cpp/dev/video_decoder_client_dev.h:41: virtual void
EndOfStream(PP_Resource decoder) = 0;
On 2012/01/11 23:50:05, Ami Fischman wrote:
> piman: is this legit to do?  IOW does the cpp/ version of the c/ interface
> always track the latest API, or what?

It's fine.
1- yes, we're trying to keep the CPP in sync with the C interface - and we don't
guarantee compatibility at that level, we just try.
2- In this case, you won't directly break anything (except OVERRIDE users).

[Ken Russell (switch to Gerrit), 2012-01-12 19:44:57]

content/common/gpu/ and content/renderer/gpu/ LGTM

[Ami GONE FROM CHROMIUM, 2012-01-12 20:25:39]

On 2012/01/12 19:44:06, piman wrote:
> cc:ihf,rbultje this will need a ppapi update in flash for accelerated video
> decode.

That can happen as a follow-up to this CL, because of API versioning, right?
(note that no plugin can rely on this method's existence at runtime because the
browser never invokes it today)

[piman, 2012-01-12 20:31:50]

On 2012/01/12 20:25:39, Ami Fischman wrote:
> On 2012/01/12 19:44:06, piman wrote:
> > cc:ihf,rbultje this will need a ppapi update in flash for accelerated video
> > decode.
> 
> That can happen as a follow-up to this CL, because of API versioning, right?

Well, it has to happen in the Flash tree, i.e. a different "CL".
The problem is that in the short term, Chrome won't find the right PPP API in
Flash, so things will break.

> (note that no plugin can rely on this method's existence at runtime because
the
> browser never invokes it today)

Yes, understood.

[piman, 2012-01-12 20:38:46]

lgtm

[commit-bot: I haz the power, 2012-01-12 20:40:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/9186022/2023

[commit-bot: I haz the power, 2012-01-12 20:40:15]

Can't apply patch for file media/filters/gpu_video_decoder.cc.
While running patch -p1 --forward --force;
patching file media/filters/gpu_video_decoder.cc
Hunk #1 FAILED at 400.
1 out of 1 hunk FAILED -- saving rejects to file
media/filters/gpu_video_decoder.cc.rej

[commit-bot: I haz the power, 2012-01-12 20:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/9186022/7002

[commit-bot: I haz the power, 2012-01-13 00:02:31]

Change committed as 117545