compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java - Issue 9186017: Fix crash in dartc when given cyclic type variable bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

Issue 9186017: Fix crash in dartc when given cyclic type variable bounds. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated unit test Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

index 0a8c9f619455213cbac5da2c80ea1c05a331f6f0..1a485a54d79850e80d4ba4bb3a5deaef6b66c8a4 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

@@ -16,6 +16,8 @@ public enum TypeErrorCode implements ErrorCode {

CANNOT_BE_RESOLVED("cannot resolve %s"),

CANNOT_OVERRIDE_TYPED_MEMBER("cannot override %s of %s because %s is not assignable to %s"),

CANNOT_OVERRIDE_METHOD_NOT_SUBTYPE("cannot override %s of %s because %s is not a subtype of %s"),

+ CYCLIC_REFERENCE_TO_TYPE_VARIABLE(

+ "Invalid type expression, cyclic reference to type variable '%s'"),

DEFAULT_CONSTRUCTOR_TYPES(

"Constructor '%s' in '%s' has parameters types (%s), doesn't match '%s' in '%s' with (%s)"),

EXTRA_ARGUMENT("extra argument"),

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | tests/language/src/CyclicTypeVariableTest.dart » ('J')