Make -Os a fatal error

Make -Os a fatal error

As per http://code.google.com/p/nativeclient/issues/detail?id=2284
using -Os produces bad code.  So disallow it until that gets fixed.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2535
TEST= tested manually

R=khim@google.com,bradchen@google.com

Committed: http://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=a767266

[Roland McGrath, 2012-01-11 19:31:56]

PTAL

[Brad Chen, 2012-01-11 20:29:36]

LGTM

On Wed, Jan 11, 2012 at 11:31 AM, <mcgrathr@chromium.org> wrote:

> Reviewers: khimg, Brad Chen,
>
> Message:
> PTAL
>
> Description:
> Make -Os a fatal error
>
> As per
http://code.google.com/p/**nativeclient/issues/detail?id=**2284<http://code.g...
> using -Os produces bad code.  So disallow it until that gets fixed.
>
> BUG=
http://code.google.com/p/**nativeclient/issues/detail?id=**2535<http://code.g...
> TEST= tested manually
>
> R=khim@google.com,bradchen@**google.com <bradchen@google.com>
>
>
> Please review this at
http://codereview.chromium.**org/9186013/<http://codereview.chromium.org/9186...
>
> SVN Base:
http://git.chromium.org/**native_client/nacl-gcc.git@**master<http://git.chro...
>
> Affected files:
>  M gcc/config/i386/nacl.h
>
>
> Index: gcc/config/i386/nacl.h
> diff --git a/gcc/config/i386/nacl.h b/gcc/config/i386/nacl.h
> index f11da3f940a3fb7b9f34c677cc9074**36daf77ebc..**
> e903e029865e098946269d95aac8de**6d69c88224 100644
> --- a/gcc/config/i386/nacl.h
> +++ b/gcc/config/i386/nacl.h
> @@ -268,3 +268,12 @@ Boston, MA 02111-1307, USA.  */
>  #define DWARF2_ADDR_SIZE \
>     (TARGET_NACL ? (TARGET_64BIT ? 8 : 4) : \
>                    (POINTER_SIZE / BITS_PER_UNIT))
> +
> +/* -Os is broken and we aren't putting the work into fixing it.
> +   See
http://code.google.com/p/**nativeclient/issues/detail?id=**2284<http://code.g...
*/
> +#undef  SUBTARGET_OVERRIDE_OPTIONS
> +#define SUBTARGET_OVERRIDE_OPTIONS
>     \
> +  do {
>     \
> +    if (TARGET_NACL && optimize_size)
>    \
> +      error ("-Os is not supported by the Native Client compiler");
>    \
> +  } while (0)
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.