Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: build/android/test_package_executable.py

Issue 9185043: Increase Android test robustness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove 'ALWAYS' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/test_package.py ('k') | build/android/test_result.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_package_executable.py
diff --git a/build/android/test_package_executable.py b/build/android/test_package_executable.py
index badea4a8e70cc336711633aef93d005c8011176e..dae8408b902a174126941e3f7aa4df26f9fc1177 100644
--- a/build/android/test_package_executable.py
+++ b/build/android/test_package_executable.py
@@ -43,6 +43,7 @@ class TestPackageExecutable(TestPackage):
def _GetGTestReturnCode(self):
ret = None
+ ret_code = 1 # Assume failure if we can't find it
ret_code_file = tempfile.NamedTemporaryFile()
try:
if not self.adb.Adb().Pull(
@@ -105,6 +106,9 @@ class TestPackageExecutable(TestPackage):
cmd_helper.RunCmd(['chmod', '+x', sh_script_file.name])
self.adb.PushIfNeeded(sh_script_file.name,
'/data/local/chrome_test_runner.sh')
+ logging.info('Conents of the test runner script: ')
+ for line in open(sh_script_file.name).readlines():
+ logging.info(' ' + line.rstrip())
def RunTestsAndListResults(self):
"""Runs all the tests and checks for failures.
« no previous file with comments | « build/android/test_package.py ('k') | build/android/test_result.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698