Avoid SYNC_CYCLE_CONTINUATION sync cycles

chrome/browser/sync/test/integration/enable_disable_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/test/integration/sync_test.h"
 
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/browser/sync/internal_api/read_node.h"
 #include "chrome/browser/sync/internal_api/read_transaction.h"
 #include "chrome/browser/sync/syncable/model_type.h"
@@ skipping 22 matching lines @@
 bool DoesTopLevelNodeExist(sync_api::UserShare* user_share,
                            syncable::ModelType type) {
     sync_api::ReadTransaction trans(FROM_HERE, user_share);
     sync_api::ReadNode node(&trans);
     return node.InitByTagLookup(syncable::ModelTypeToRootTag(type));
 }
 
 IN_PROC_BROWSER_TEST_F(EnableDisableSingleClientTest, EnableOneAtATime) {
   ASSERT_TRUE(SetupClients());
 
-  DisableNotifications();
-
   // Setup sync with no enabled types.
   ASSERT_TRUE(GetClient(0)->SetupSync(syncable::ModelTypeSet()));
 
+  // TODO(rlarocque, 97780): It should be possible to disable notifications
+  // before calling SetupSync().  We should move this line back to the top
+  // of this function when this is supported.
+  DisableNotifications();
+
   const syncable::ModelTypeSet registered_types =
       GetClient(0)->service()->GetRegisteredDataTypes();
   sync_api::UserShare* user_share = GetClient(0)->service()->GetUserShare();
   for (syncable::ModelTypeSet::Iterator it = registered_types.First();
        it.Good(); it.Inc()) {
     ASSERT_TRUE(GetClient(0)->EnableSyncForDatatype(it.Get()));
 
     // AUTOFILL_PROFILE is lumped together with AUTOFILL.
     if (it.Get() == syncable::AUTOFILL_PROFILE) {
       continue;
     }
 
     ASSERT_TRUE(DoesTopLevelNodeExist(user_share, it.Get()))
         << syncable::ModelTypeToString(it.Get());
 
     // AUTOFILL_PROFILE is lumped together with AUTOFILL.
     if (it.Get() == syncable::AUTOFILL) {
       ASSERT_TRUE(DoesTopLevelNodeExist(user_share,
                                         syncable::AUTOFILL_PROFILE));
     }
   }
 
   EnableNotifications();
 }
 
 IN_PROC_BROWSER_TEST_F(EnableDisableSingleClientTest, DisableOneAtATime) {
   ASSERT_TRUE(SetupClients());
 
-  DisableNotifications();
-
   // Setup sync with no disabled types.
   ASSERT_TRUE(GetClient(0)->SetupSync());
 
+  // TODO(rlarocque, 97780): It should be possible to disable notifications
+  // before calling SetupSync().  We should move this line back to the top
+  // of this function when this is supported.
+  DisableNotifications();
+
   const syncable::ModelTypeSet registered_types =
       GetClient(0)->service()->GetRegisteredDataTypes();
 
   sync_api::UserShare* user_share = GetClient(0)->service()->GetUserShare();
 
   // Make sure all top-level nodes exist first.
   for (syncable::ModelTypeSet::Iterator it = registered_types.First();
        it.Good(); it.Inc()) {
     ASSERT_TRUE(DoesTopLevelNodeExist(user_share, it.Get()));
   }
@@ skipping 17 matching lines @@
     if (it.Get() == syncable::AUTOFILL) {
       ASSERT_FALSE(DoesTopLevelNodeExist(user_share,
                                          syncable::AUTOFILL_PROFILE));
     }
   }
 
   EnableNotifications();
 }
 
 }  // namespace