Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2720)

Unified Diff: chrome/browser/task_manager/task_manager.cc

Issue 9185026: Convert use of int ms to TimeDelta in files owned by brettw. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove static class initializations. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager.cc
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 9015f1499a3f85f8ac3fa43e2e5cad7a7c2db4e5..c857fe24e32907907d458f59955124c9d498a464 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -47,6 +47,7 @@
#include "content/browser/mach_broker_mac.h"
#endif
+using base::TimeDelta;
brettw 2012/01/15 17:28:15 It's not clear why you did this here when most of
using content::BrowserThread;
using content::OpenURLParams;
using content::Referrer;
@@ -627,8 +628,9 @@ void TaskManagerModel::StartUpdating() {
// it to TASK_PENDING ensures the tasks keep being posted (by Refresh()).
if (update_state_ == IDLE) {
MessageLoop::current()->PostDelayedTask(
- FROM_HERE, base::Bind(&TaskManagerModel::Refresh, this),
- kUpdateTimeMs);
+ FROM_HERE,
+ base::Bind(&TaskManagerModel::Refresh, this),
+ base::TimeDelta::FromMilliseconds(kUpdateTimeMs));
}
update_state_ = TASK_PENDING;
@@ -870,14 +872,15 @@ void TaskManagerModel::Refresh() {
// Compute the new network usage values.
displayed_network_usage_map_.clear();
+ TimeDelta update_time = base::TimeDelta::FromMilliseconds(kUpdateTimeMs);
for (ResourceValueMap::iterator iter = current_byte_count_map_.begin();
iter != current_byte_count_map_.end(); ++iter) {
- if (kUpdateTimeMs > 1000) {
- int divider = (kUpdateTimeMs / 1000);
+ if (update_time > TimeDelta::FromSeconds(1)) {
+ int divider = update_time.InSeconds();
displayed_network_usage_map_[iter->first] = iter->second / divider;
} else {
displayed_network_usage_map_[iter->first] = iter->second *
- (1000 / kUpdateTimeMs);
+ (1 / update_time.InSeconds());
}
// Then we reset the current byte count.
@@ -897,7 +900,9 @@ void TaskManagerModel::Refresh() {
// Schedule the next update.
MessageLoop::current()->PostDelayedTask(
- FROM_HERE, base::Bind(&TaskManagerModel::Refresh, this), kUpdateTimeMs);
+ FROM_HERE,
+ base::Bind(&TaskManagerModel::Refresh, this),
+ base::TimeDelta::FromMilliseconds(kUpdateTimeMs));
}
int64 TaskManagerModel::GetNetworkUsageForResource(

Powered by Google App Engine
This is Rietveld 408576698