Compile libvpx code as PIC for all Linux targets

Compile libvpx code as PIC for all Linux targets

TEXTRELs (i.e. non-PIC code in a DSO or PIE such as chrome) are a bad
bad thing on Linux.  As of M16 we managed to get rid of all of them
(except for libffmpegsumo.so, where it will take a bunch of work).  In
M17 this regressed, due to the libvpx code.  This makes users of Linux
distributions such as Fedora very unhappy.

It's a simple configuration change to tell libvpx to build PIC on ia32.
This gets rid of all TEXTRELs in the chrome build again.

BUG= http://code.google.com/p/chromium/issues/detail?id=109318
TEST= none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117274

[Roland McGrath, 2012-01-11 18:53:12]

It's not clear to me whether this alone is sufficient to make sure the change
sticks in the future.  This file looks like a generated file.  But I couldn't
figure out how it's regenerated, and generate_gypi.sh has a comment saying it
has to be updated manually.

PTAL


Thanks,
Roland

[Roland McGrath, 2012-01-11 19:27:23]

I harmonized all the occurrences of CONFIG_PIC though I think the first patch
changed the only thing that has any practical effect.

[jkoleszar, 2012-01-11 19:44:14]

On 2012/01/11 19:27:23, Roland McGrath wrote:
> I harmonized all the occurrences of CONFIG_PIC though I think the first patch
> changed the only thing that has any practical effect.

LGTM

nit: this patch also has the effect of turning on PIC on ARM, which I suspect is
the right thing to do anyway, but you may want to change the subject of this
patch to indicate 'all targets' or alternately define it for CONFIG_X86 instead
of CONFIG_COMMON.