Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 9184002: Add custom field converter to JSONValueConverter. (Closed)

Created:
8 years, 11 months ago by Jun Mukai
Modified:
8 years, 11 months ago
Reviewers:
awong, Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org, zel, satorux1, willchan no longer on Chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add custom field converter to JSONValueConverter. In the real JSON results, sometimes string value does not literally mean a string, but labels (enum), URLs, or timestamps. Custom field accepts those string values and converting functions for such fields. See http://codereview.chromium.org/9147060 for the real use cases. BUG=109375 TEST=passed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117580

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments for custom fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M base/json/json_value_converter.h View 1 4 chunks +48 lines, -0 lines 0 comments Download
M base/json/json_value_converter_unittest.cc View 5 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
8 years, 11 months ago (2012-01-11 06:29:45 UTC) #1
Evan Martin
LGTM
8 years, 11 months ago (2012-01-11 17:20:09 UTC) #2
awong
http://codereview.chromium.org/9184002/diff/1/base/json/json_value_converter.h File base/json/json_value_converter.h (right): http://codereview.chromium.org/9184002/diff/1/base/json/json_value_converter.h#newcode69 base/json/json_value_converter.h:69: // RegisterRepeatedMessage for nested repeated fields. Can we add ...
8 years, 11 months ago (2012-01-11 17:32:13 UTC) #3
Jun Mukai
http://codereview.chromium.org/9184002/diff/1/base/json/json_value_converter.h File base/json/json_value_converter.h (right): http://codereview.chromium.org/9184002/diff/1/base/json/json_value_converter.h#newcode69 base/json/json_value_converter.h:69: // RegisterRepeatedMessage for nested repeated fields. On 2012/01/11 17:32:13, ...
8 years, 11 months ago (2012-01-12 07:17:18 UTC) #4
awong
LGTM
8 years, 11 months ago (2012-01-12 18:40:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/9184002/6003
8 years, 11 months ago (2012-01-13 00:11:37 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-13 02:18:05 UTC) #7
Change committed as 117580

Powered by Google App Engine
This is Rietveld 408576698