Don't activate a window if screen is locked.

ash/wm/window_cycle_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_cycle_controller.h"
 
 #include <algorithm>
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 26 matching lines @@
 
   // Cycling doesn't crash if there are no windows.
   EXPECT_TRUE(Shell::GetInstance()->delegate()->GetCycleWindowList().empty());
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
 
   // Create a single test window.
   Window* default_container =
       ash::Shell::GetInstance()->GetContainer(
           internal::kShellWindowId_DefaultContainer);
   scoped_ptr<Window> window0(CreateTestWindowWithId(0, default_container));
+  window0->Show();
   ActivateWindow(window0.get());
   EXPECT_TRUE(IsActiveWindow(window0.get()));
 
   // Cycling works for a single window, even though nothing changes.
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_TRUE(IsActiveWindow(window0.get()));
 }
 
 TEST_F(WindowCycleControllerTest, HandleCycleWindow) {
   WindowCycleController* controller =
       Shell::GetInstance()->window_cycle_controller();
 
   // Set up several windows to use to test cycling.  Create them in reverse
   // order so they are stacked 0 over 1 over 2.
   Window* default_container =
       Shell::GetInstance()->GetContainer(
           internal::kShellWindowId_DefaultContainer);
   scoped_ptr<Window> window2(CreateTestWindowWithId(2, default_container));
   scoped_ptr<Window> window1(CreateTestWindowWithId(1, default_container));
   scoped_ptr<Window> window0(CreateTestWindowWithId(0, default_container));
+  window0->Show();
+  window1->Show();
+  window2->Show();
   ActivateWindow(window0.get());
 
   // Window lists should return the topmost window in front.
   std::vector<Window*> windows =
       Shell::GetInstance()->delegate()->GetCycleWindowList();
   ASSERT_EQ(3u, windows.size());
   ASSERT_EQ(window0.get(), windows[0]);
   ASSERT_EQ(window1.get(), windows[1]);
   ASSERT_EQ(window2.get(), windows[2]);
 
@@ skipping 45 matching lines @@
   // Passing false for is_alt_down does not start a cycle gesture.
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_FALSE(controller->IsCycling());
   EXPECT_TRUE(IsActiveWindow(window1.get()));
 
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_FALSE(controller->IsCycling());
   EXPECT_TRUE(IsActiveWindow(window0.get()));
 
   // When a screen lock window is visible, cycling window does not take effect.
-  aura::Window* lock_screen_container =
-      Shell::GetInstance()->GetContainer(
-          internal::kShellWindowId_LockScreenContainer);
   scoped_ptr<Window> lock_screen_window(
-      CreateTestWindowWithId(-1, lock_screen_container));
+      CreateTestWindowWithId(-1, default_container));
+  lock_screen_window->set_stops_event_propagation(true);
+  lock_screen_window->SetParent(NULL);
   lock_screen_window->Show();
   EXPECT_TRUE(IsActiveWindow(window0.get()));
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_TRUE(IsActiveWindow(window0.get()));
   controller->HandleCycleWindow(WindowCycleController::BACKWARD, false);
   EXPECT_TRUE(IsActiveWindow(window0.get()));
 
   // Hiding the lock screen is equivalent to not being locked.
   lock_screen_window->Hide();
   EXPECT_TRUE(IsActiveWindow(window0.get()));
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_TRUE(IsActiveWindow(window1.get()));
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_TRUE(IsActiveWindow(window0.get()));
 
   // When a modal window is active, cycling window does not take effect.
   aura::Window* modal_container =
       ash::Shell::GetInstance()->GetContainer(
           internal::kShellWindowId_AlwaysOnTopContainer);
   scoped_ptr<Window> modal_window(
       CreateTestWindowWithId(-2, modal_container));
+  modal_window->Show();
   ActivateWindow(modal_window.get());
   EXPECT_TRUE(IsActiveWindow(modal_window.get()));
   controller->HandleCycleWindow(WindowCycleController::FORWARD, false);
   EXPECT_TRUE(IsActiveWindow(modal_window.get()));
   EXPECT_FALSE(IsActiveWindow(window0.get()));
   EXPECT_FALSE(IsActiveWindow(window1.get()));
   EXPECT_FALSE(IsActiveWindow(window2.get()));
   controller->HandleCycleWindow(WindowCycleController::BACKWARD, false);
   EXPECT_TRUE(IsActiveWindow(modal_window.get()));
   EXPECT_FALSE(IsActiveWindow(window0.get()));
   EXPECT_FALSE(IsActiveWindow(window1.get()));
   EXPECT_FALSE(IsActiveWindow(window2.get()));
 }
 
 }  // namespace ash