Issue 9178019: Overhaul breakpad to optionally disable output. Add git-cl dcommit unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9178019: Overhaul breakpad to optionally disable output. Add git-cl dcommit unit test. (Closed)

Created:
8 years, 11 months ago by M-A Ruel

Modified:
8 years, 11 months ago

Reviewers:
cmp

CC:
chromium-reviews, Dirk Pranke, M-A Ruel, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Overhaul breakpad to optionally disable output. Add git-cl dcommit unit test. This required fixing the adhoc mock to be more versatile. TBR=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117896

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+201 lines, -99 lines)			Patch
M	breakpad.py	View	2 chunks	+34 lines, -38 lines	0 comments	Download
M	gcl.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	git_cl.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/git_cl_test.py	View	4 chunks	+162 lines, -59 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9178019/1

8 years, 11 months ago (2012-01-17 15:12:14 UTC) #2

lgtm