PPAPI URLRequestInfo test: port NaCl version to ppapi_tests. Fix Var and Resource leaks.

chrome/test/ui/ppapi_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/test/test_timeouts.h"
 #include "build/build_config.h"
 #include "content/public/common/content_switches.h"
@@ skipping 447 matching lines @@
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_StreamToFile)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_UntrustedSameOriginRestriction)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_UntrustedCrossOriginRequest)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_UntrustedJavascriptURLRestriction)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_UntrustedHttpRestriction)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_FollowURLRedirect)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_AuditURLRedirect)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_AbortCalls)
 TEST_PPAPI_NACL_VIA_HTTP(URLLoader_UntendedLoad)
 
+// URLRequestInfo tests.
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLRequest_Create)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(URLRequest_Create)
+TEST_PPAPI_NACL_VIA_HTTP(URLRequest_Create)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLRequest_IsURLRequestInfo)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(URLRequest_IsURLRequestInfo)
+TEST_PPAPI_NACL_VIA_HTTP(URLRequest_IsURLRequestInfo)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLRequest_SetProperty)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(URLRequest_SetProperty)
+TEST_PPAPI_NACL_VIA_HTTP(URLRequest_SetProperty)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLRequest_AppendDataToBody)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(URLRequest_AppendDataToBody)
+TEST_PPAPI_NACL_VIA_HTTP(URLRequest_AppendDataToBody)
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(URLRequest_Stress)
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(URLRequest_Stress)
+TEST_PPAPI_NACL_VIA_HTTP(URLRequest_Stress)

[bbudge, 2012/01/16 16:24:29]

Each PPAPITest takes 10-20 seconds to run. Could we collapse the really basic
ones like Create, IsURLRequestInfo, and SetProperty into a single test, ala
ResourceArray_Basics, below?

[polina1, 2012/01/26 02:56:26]

I think it is a very good idea to combine the first two (and I did), but not
convinced that SetProperty should be merged as well. It pretty long and
detailed. And I think the whole point of separate test cases was to be able to
narrow things down and disable/enable them independently of the rest.

+
 TEST_PPAPI_IN_PROCESS(PaintAggregator)
 TEST_PPAPI_OUT_OF_PROCESS(PaintAggregator)
 TEST_PPAPI_NACL_VIA_HTTP(PaintAggregator)
 
 TEST_PPAPI_IN_PROCESS(Scrollbar)
 // http://crbug.com/89961
 TEST_F(OutOfProcessPPAPITest, FAILS_Scrollbar) {
   RunTest("Scrollbar");
 }
 TEST_PPAPI_NACL_VIA_HTTP(Scrollbar)
@@ skipping 277 matching lines @@
 TEST_PPAPI_IN_PROCESS(ResourceArray_Basics)
 TEST_PPAPI_IN_PROCESS(ResourceArray_OutOfRangeAccess)
 TEST_PPAPI_IN_PROCESS(ResourceArray_EmptyArray)
 TEST_PPAPI_IN_PROCESS(ResourceArray_InvalidElement)
 TEST_PPAPI_OUT_OF_PROCESS(ResourceArray_Basics)
 TEST_PPAPI_OUT_OF_PROCESS(ResourceArray_OutOfRangeAccess)
 TEST_PPAPI_OUT_OF_PROCESS(ResourceArray_EmptyArray)
 TEST_PPAPI_OUT_OF_PROCESS(ResourceArray_InvalidElement)
 
 #endif // ADDRESS_SANITIZER