Roll libjingle to r108.

Roll libjingle to r108:
* Add app/webrtc.
* Add examples/peerconnection.
* Bug fixes.

Roll webrtc to 1311.

BUG=110255
TEST=build and unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118031

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118254

[Sergey Ulanov, 2012-01-13 20:45:19]

Why not r107?

[Ronghua Wu (Left Chromium), 2012-01-13 20:49:23]

On 2012/01/13 20:45:19, sergeyu wrote:
> Why not r107?

r107 enables SRTP for peerconnection v1 which turns out doesn't work with the
test app. So I want to roll r106 first to bring in some fixes we need and at the
same time investigating the problem in r107.

Please ignore the trybot result for now since I was trying against a too old
version.

[Sergey Ulanov, 2012-01-13 21:57:53]

LGTM

[wjia(left Chromium), 2012-01-13 22:14:19]

lgtm after filename order is fixed.

http://codereview.chromium.org/9174012/diff/6002/third_party/libjingle/libjin...
File third_party/libjingle/libjingle.gyp (right):

http://codereview.chromium.org/9174012/diff/6002/third_party/libjingle/libjin...
third_party/libjingle/libjingle.gyp:297: 'source/talk/base/timeutils.cc',
name order.

[Ronghua Wu (Left Chromium), 2012-01-13 22:17:36]

http://codereview.chromium.org/9174012/diff/6002/third_party/libjingle/libjin...
File third_party/libjingle/libjingle.gyp (right):

http://codereview.chromium.org/9174012/diff/6002/third_party/libjingle/libjin...
third_party/libjingle/libjingle.gyp:297: 'source/talk/base/timeutils.cc',
On 2012/01/13 22:14:19, wjia wrote:
> name order.

Done.

[commit-bot: I haz the power, 2012-01-13 22:20:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9174012/2004

[Ronghua Wu (Left Chromium), 2012-01-17 23:08:45]

Cl updated to roll libjingle r108 instead of r106. Roll the webrtc version as
well.

[Sergey Ulanov, 2012-01-17 23:21:03]

LGTM with one nit.

https://chromiumcodereview.appspot.com/9174012/diff/11001/third_party/libjing...
File third_party/libjingle/overrides/talk/base/basictypes.h (right):

https://chromiumcodereview.appspot.com/9174012/diff/11001/third_party/libjing...
third_party/libjingle/overrides/talk/base/basictypes.h:63: #define
LIBJINGLE_DEFINE_STATIC_LOCAL(a,b,c) CR_DEFINE_STATIC_LOCAL(a,b,c)
Better to expand the argument names too (type, name, arguments), instead of
a,b,c. Also need spaces between the arguments.
Also add some comment saying that LIBJINGLE_DEFINE_STATIC_LOCAL() is a
libjingle's copy of CR_DEFINE_STATIC_LOCAL().

[Ronghua Wu (Left Chromium), 2012-01-17 23:29:14]

https://chromiumcodereview.appspot.com/9174012/diff/11001/third_party/libjing...
File third_party/libjingle/overrides/talk/base/basictypes.h (right):

https://chromiumcodereview.appspot.com/9174012/diff/11001/third_party/libjing...
third_party/libjingle/overrides/talk/base/basictypes.h:63: #define
LIBJINGLE_DEFINE_STATIC_LOCAL(a,b,c) CR_DEFINE_STATIC_LOCAL(a,b,c)
On 2012/01/17 23:21:03, sergeyu wrote:
> Better to expand the argument names too (type, name, arguments), instead of
> a,b,c. Also need spaces between the arguments.
> Also add some comment saying that LIBJINGLE_DEFINE_STATIC_LOCAL() is a
> libjingle's copy of CR_DEFINE_STATIC_LOCAL().

Done.

[commit-bot: I haz the power, 2012-01-17 23:57:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9174012/11010

[commit-bot: I haz the power, 2012-01-18 03:37:49]

Change committed as 118031

[Ronghua Wu (Left Chromium), 2012-01-18 05:12:00]

Got failure in Chromium Memory test. Will try to land again after the fix. 

Suppression (error hash=#0B1DA82040F34ABC#):
{
   <insert_a_suppression_name_here>
   Heapcheck:Leak
   fun:talk_base::ThreadManager::WrapCurrentThread
   fun:talk_base::ThreadManager::ThreadManager
   fun:talk_base::ThreadManager::Instance
   fun:jingle_glue::JingleThreadWrapper::JingleThreadWrapper
   fun:jingle_glue::JingleThreadWrapper::EnsureForCurrentThread
   fun:content::P2PTransportImpl::Init
   fun:content::P2PTransportImplTest::Init
   fun:content::P2PTransportImplTest_Create_Test::TestBody
}

[Sergey Ulanov, 2012-01-18 06:16:26]

On 2012/01/18 05:12:00, Ronghua Wu wrote:
> Got failure in Chromium Memory test. Will try to land again after the fix. 
> 
> Suppression (error hash=#0B1DA82040F34ABC#):
> {
>    <insert_a_suppression_name_here>
>    Heapcheck:Leak
>    fun:talk_base::ThreadManager::WrapCurrentThread
>    fun:talk_base::ThreadManager::ThreadManager
>    fun:talk_base::ThreadManager::Instance
>    fun:jingle_glue::JingleThreadWrapper::JingleThreadWrapper
>    fun:jingle_glue::JingleThreadWrapper::EnsureForCurrentThread
>    fun:content::P2PTransportImpl::Init
>    fun:content::P2PTransportImplTest::Init
>    fun:content::P2PTransportImplTest_Create_Test::TestBody
> }

I think that leak that was there for very long time. It's just that it was never
detected by valgrind because ThreadManager used to keep references to all
running threads. I removed ThreadManager.threads_, and so now valgrind can
detect this leak. It's a one-time leak, so you could just suppress this and
other warnings until the leak is fixed in libjingle.

[Ronghua Wu (Left Chromium), 2012-01-18 07:10:08]

Merge the fix for the memory leak from http://codereview.chromium.org/9255010/.

[commit-bot: I haz the power, 2012-01-18 17:57:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9174012/24002

[commit-bot: I haz the power, 2012-01-18 20:57:26]

Try job failure for 9174012-24002 (retry) on win_rel for steps
"jingle_unittests, content_unittests".
It's a second try, previously, steps "jingle_unittests, content_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Ronghua Wu (Left Chromium), 2012-01-18 23:44:36]

We should UnwrapCurrent the thread before delete it. Otherwise it will hit the
assert in the dctor.

[Sergey Ulanov, 2012-01-19 01:36:22]

https://chromiumcodereview.appspot.com/9174012/diff/25003/jingle/glue/thread_...
File jingle/glue/thread_wrapper.cc (right):

https://chromiumcodereview.appspot.com/9174012/diff/25003/jingle/glue/thread_...
jingle/glue/thread_wrapper.cc:55: current_thread->UnwrapCurrent();
Add DCHECK(!current_thread->Owned()); here.

[Sergey Ulanov, 2012-01-19 01:36:39]

LGTM when dcheck is added.

On 2012/01/19 01:36:22, sergeyu wrote:
>
https://chromiumcodereview.appspot.com/9174012/diff/25003/jingle/glue/thread_...
> File jingle/glue/thread_wrapper.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9174012/diff/25003/jingle/glue/thread_...
> jingle/glue/thread_wrapper.cc:55: current_thread->UnwrapCurrent();
> Add DCHECK(!current_thread->Owned()); here.

[Ronghua Wu (Left Chromium), 2012-01-19 03:22:51]

As discussed, use UnwrapCurrentThread instead.

[commit-bot: I haz the power, 2012-01-19 03:24:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9174012/31001

[commit-bot: I haz the power, 2012-01-19 06:18:30]

Change committed as 118254