Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 9173007: Fix flaky idle notification test. (Closed)

Created:
8 years, 11 months ago by ulan
Modified:
8 years, 11 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix flaky idle notification test. Idle notification handler might not free more memory if there was a global GC before or incremental marking is not activated (and it's not worth activating). BUG= TEST=cctest/test-api/IdleNotificationWithHint Committed: http://code.google.com/p/v8/source/detail?r=10401

Patch Set 1 : Fix flaky idle notification test. #

Patch Set 2 : Use always allocate scope and not threading test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M test/cctest/test-api.cc View 1 1 chunk +16 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Please take a look.
8 years, 11 months ago (2012-01-13 13:44:24 UTC) #1
Erik Corry
I feel like the test is not testing much after this change. Would making it ...
8 years, 11 months ago (2012-01-13 15:02:21 UTC) #2
ulan
On 2012/01/13 15:02:21, Erik Corry wrote: > I feel like the test is not testing ...
8 years, 11 months ago (2012-01-13 17:06:44 UTC) #3
Erik Corry
8 years, 11 months ago (2012-01-14 01:44:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698