Make heap size estimation more accurate.

src/spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 731 matching lines @@
   PageIterator it(this);
   int count = 0;
   while (it.has_next()) {
     it.next();
     count++;
   }
   return count;
 }
 
 
+intptr_t PagedSpace::SizeOfObjectsSlow() {

[Vyacheslav Egorov (Chromium), 2012/01/10 17:42:43]

we will call this function at least once at the end of GC (see garbage
collection epilogue).

I wonder if you can compute sum of "delayed" live bytes while in
MarkCompactCollector::SweepSpace and then adjust it while lazy sweeping
progresses.

[Michael Starzinger, 2012/01/11 09:55:57]

Done. Yes, we can.

+  PageIterator it(this);
+  intptr_t size_of_objects = accounting_stats_.Size();
+  while (it.has_next()) {
+    Page* p = it.next();
+    if (!p->WasSwept()) {
+      size_of_objects -= Page::kObjectAreaSize;
+      size_of_objects += p->LiveBytes();
+    }
+  }
+  return size_of_objects - (limit() - top());
+}
+
+
 void PagedSpace::ReleasePage(Page* page) {
   ASSERT(page->LiveBytes() == 0);
 
   // Adjust list of unswept pages if the page is the head of the list.
   if (first_unswept_page_ == page) {
     first_unswept_page_ = page->next_page();
     if (first_unswept_page_ == anchor()) {
       first_unswept_page_ = Page::FromAddress(NULL);
     }
   }
@@ skipping 1896 matching lines @@
     object->ShortPrint();
     PrintF("\n");
   }
   printf(" --------------------------------------\n");
   printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
 }
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal