Fix variable aliasing. Fixes pylint W0623.

tests/subprocess2_test.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for subprocess2.py."""
 
 import logging
 import optparse
 import os
@@ skipping 235 matching lines @@
         pass
 
   def test_check_output_throw_stdout(self):
     def fn(c, e, un, subp):
       if not hasattr(subp, 'check_output'):
         return
       try:
         subp.check_output(
             e + ['--fail', '--stdout'], universal_newlines=un)
         self.fail()
-      except subp.CalledProcessError, e:
-        self._check_exception(subp, e, c('A\nBB\nCCC\n'), None, 64)
+      except subp.CalledProcessError, exception:
+        self._check_exception(subp, exception, c('A\nBB\nCCC\n'), None, 64)
     self._run_test(fn)
 
   def test_check_output_throw_no_stderr(self):
     def fn(c, e, un, subp):
       if not hasattr(subp, 'check_output'):
         return
       try:
         subp.check_output(
             e + ['--fail', '--stderr'], universal_newlines=un)
         self.fail()
-      except subp.CalledProcessError, e:
-        self._check_exception(subp, e, c(''), None, 64)
+      except subp.CalledProcessError, exception:
+        self._check_exception(subp, exception, c(''), None, 64)
     self._run_test(fn)
 
   def test_check_output_throw_stderr(self):
     def fn(c, e, un, subp):
       if not hasattr(subp, 'check_output'):
         return
       try:
         subp.check_output(
             e + ['--fail', '--stderr'],
             stderr=subp.PIPE,
             universal_newlines=un)
         self.fail()
-      except subp.CalledProcessError, e:
-        self._check_exception(subp, e, '', c('a\nbb\nccc\n'), 64)
+      except subp.CalledProcessError, exception:
+        self._check_exception(subp, exception, '', c('a\nbb\nccc\n'), 64)
     self._run_test(fn)
 
   def test_check_output_throw_stderr_stdout(self):
     def fn(c, e, un, subp):
       if not hasattr(subp, 'check_output'):
         return
       try:
         subp.check_output(
             e + ['--fail', '--stderr'],
             stderr=subp.STDOUT,
             universal_newlines=un)
         self.fail()
-      except subp.CalledProcessError, e:
-        self._check_exception(subp, e, c('a\nbb\nccc\n'), None, 64)
+      except subp.CalledProcessError, exception:
+        self._check_exception(subp, exception, c('a\nbb\nccc\n'), None, 64)
     self._run_test(fn)
 
   def test_check_call_throw(self):
     for subp in (subprocess, subprocess2):
       try:
         subp.check_call(self.exe + ['--fail', '--stderr'])
         self.fail()
-      except subp.CalledProcessError, e:
-        self._check_exception(subp, e, None, None, 64)
+      except subp.CalledProcessError, exception:
+        self._check_exception(subp, exception, None, None, 64)
 
   def test_redirect_stderr_to_stdout_pipe(self):
     def fn(c, e, un, subp):
       # stderr output into stdout.
       proc = subp.Popen(
           e + ['--stderr'],
           stdout=subp.PIPE,
           stderr=subp.STDOUT,
           universal_newlines=un)
       res = proc.communicate(), proc.returncode
@@ skipping 179 matching lines @@
   def test_tee_throw(self):
     def fn(c, e, un):
       # Make sure failure still returns stderr completely.
       stderr = []
       try:
         subprocess2.check_output(
             e + ['--stderr', '--fail'],
             stderr=stderr.append,
             universal_newlines=un)
         self.fail()
-      except subprocess2.CalledProcessError, e:
-        self._check_exception(e, '', None, 64)
+      except subprocess2.CalledProcessError, exception:
+        self._check_exception(exception, '', None, 64)
         self.assertEquals(c('a\nbb\nccc\n'), ''.join(stderr))
     self._run_test(fn)
 
   def test_tee_timeout_stdout_void(self):
     def fn(c, e, un):
       stderr = []
       res = subprocess2.communicate(
           e + ['--stdout', '--stderr', '--fail'],
           stdout=VOID,
           stderr=stderr.append,
@@ skipping 124 matching lines @@
   return options.return_value
 
 
 if __name__ == '__main__':
   logging.basicConfig(level=
       [logging.WARNING, logging.INFO, logging.DEBUG][
         min(2, sys.argv.count('-v'))])
   if len(sys.argv) > 1 and sys.argv[1] == '--child':
     sys.exit(child_main(sys.argv[2:]))
   unittest.main()