Add Dart_PropagateError.

runtime/vm/ast.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/ast.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/isolate.h"
 #include "vm/object_store.h"
 
@@ skipping 420 matching lines @@
 const Instance* StaticGetterNode::EvalConstExpr() const {
   const String& getter_name =
       String::Handle(Field::GetterName(this->field_name()));
   const Function& getter_func =
       Function::Handle(this->cls().LookupStaticFunction(getter_name));
   if (getter_func.IsNull() || !getter_func.is_const()) {
     return NULL;
   }
   GrowableArray<const Object*> arguments;
   const Array& kNoArgumentNames = Array::Handle();
-  const Instance& field_value =
-      Instance::ZoneHandle(DartEntry::InvokeStatic(getter_func,
+  const Object& result =
+      Object::ZoneHandle(DartEntry::InvokeStatic(getter_func,
                                                    arguments,
                                                    kNoArgumentNames));

[siva, 2012/01/31 00:52:34]

Does result have to be a ZoneHandle? We are not returning this handle from the
function.

[turnidge, 2012/01/31 21:56:31]

Done.

-  if (field_value.IsUnhandledException()) {
+  if (result.IsError()) {
+    // TODO(turnidge): We could get better error messages by returning
+    // the Error object directly to the parser.  This will involve
+    // replumbing all of the EvalConstExpr methods.
     return NULL;
   }
-  if (!field_value.IsNull()) {
-    return &field_value;
+  ASSERT(result.IsInstance());

[siva, 2012/01/31 00:52:34]

Why is this assert needed here doesn't the ^= assignment below have the same
assertion?

[turnidge, 2012/01/31 21:56:31]

 Removed.

+  Instance& value = Instance::ZoneHandle();

[siva, 2012/01/31 00:52:34]

why not call it field_value instead of value to retain the old code

[turnidge, 2012/01/31 21:56:31]

Done.

+  value ^= result.raw();
+  if (!value.IsNull()) {

[siva, 2012/01/31 00:52:34]

The NULL check can be done before we create an Instance handle that way we save
on a handle creation.

[turnidge, 2012/01/31 21:56:31]

Done.

+    return &value;
   }
   return NULL;
 }
 
 }  // namespace dart