Add a custom SVNPoller implementation that adds " (CQ)" to author name for

Add a custom SVNPoller implementation that adds " (CQ)" to author name for
commits that go through the commit-queue.

BUG=106658
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119291

[M-A Ruel, 2012-01-26 20:30:55]

BTW it's seriously awesome.

Just a few nits and it should be fine afterward. Then if it's work fines on the
real master, we can convert all the ones that make sense.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py
File scripts/master/svnpoller.py (right):

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:5: """ Source file for buildbot.changes.svnpoller
module modifications. """
Not really informative. Add a class docstring """Adds necessary information to
had (CQ) tag to waterfall/console views""" or something like that to explain the
end goal.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:11: self.old_create_changes = self.create_changes
Remove.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:13: def get_logs(self, _):
Add a single line docstring explaining why the change.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:18: args.extend(["--username=%s" % self.svnuser])
Align at +2. Yeah it's confusing...

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:25: def create_changes(self, new_logentries):
Add a single line docstring explaining why the change.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:39: changes =
self.old_create_changes(new_logentries)
changes = svnpoller.SVNPoller.create_changes(self, new_logentries)

[sadrul, 2012-01-26 20:45:18]

Thanks for the quick reviews! Addressed the comments.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py
File scripts/master/svnpoller.py (right):

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:5: """ Source file for buildbot.changes.svnpoller
module modifications. """
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> Not really informative. Add a class docstring """Adds necessary information to
> had (CQ) tag to waterfall/console views""" or something like that to explain
the
> end goal.

Done.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:11: self.old_create_changes = self.create_changes
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> Remove.

Done.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:13: def get_logs(self, _):
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> Add a single line docstring explaining why the change.

Done.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:18: args.extend(["--username=%s" % self.svnuser])
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> Align at +2. Yeah it's confusing...

Done.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:25: def create_changes(self, new_logentries):
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> Add a single line docstring explaining why the change.

Done.

http://codereview.chromium.org/9169097/diff/5/scripts/master/svnpoller.py#new...
scripts/master/svnpoller.py:39: changes =
self.old_create_changes(new_logentries)
On 2012/01/26 20:30:55, Marc-Antoine Ruel wrote:
> changes = svnpoller.SVNPoller.create_changes(self, new_logentries)

Nice! Done.

[M-A Ruel, 2012-01-26 21:07:20]

lgtm

I'll look at restarting FYI tomorrow morning to see how it goes, then we can
look at converting the remaining ones.

Thanks!

[commit-bot: I haz the power, 2012-01-26 21:10:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sadrul@chromium.org/9169097/4003

[commit-bot: I haz the power, 2012-01-26 21:13:29]

Change committed as 119291