Remove a bunch of GetProfileSyncService callers to use the new factory.

Remove a bunch of GetProfileSyncService callers to use the new factory.

This is mostly everything except code under /sync or sync_internals (those require a little more time
as they have unit test implications).  The ones here are quite simple but need several owner-approvals, and given the upcoming 18 branch I'd like
to get this landed without a cross-team monday crunch :)

TBR=jhawkins@chromium.org
TBR=mirandac@chromium.org
TBR=isherman@chromium.org
TBR=nkostylev@chromium.org
TBR=estade@chromium.org

BUG=93922
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119482

[tim (not reviewing), 2012-01-26 20:20:40]

mihaip: Please review /extensions (note 'TODO(REVIEWERS)' question)

atwilson: Please review everything.

Everyone else, FYI 
georgey: autofill FYI
kochi: chromeos FYI
jhawkins: webui FYI
mirandac: profiles FYI
sky: browser/ui FYI

Thanks!

[Mihai Parparita -not on Chrome, 2012-01-26 20:24:40]

http://codereview.chromium.org/9169096/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_ui.cc (right):

http://codereview.chromium.org/9169096/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_ui.cc:128: // TODO(REVIEWERS): Why
does this not use OriginalProfile but above we do?
Anthony knows this code better.

[sky, 2012-01-26 21:01:09]

chrome/browser/ui LGTM

[Andrew T Wilson (Slow), 2012-01-26 23:09:09]

LGTM with some completely utterly ignorable nits (except for the compilation
error).

One thing I'll note:

ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile) is sooo many
characters.

The pattern I used for SigninManager was to define a method on
SigninManagerFactory that combined GetInstance() and GetForProfile():

  // Returns the instance of SigninManager associated with this profile
  // (creating one if none exists). Returns NULL if this profile cannot have a
  // SigninManager (for example, if |profile| is incognito).
  static SigninManager* GetForProfile(Profile* profile);

That way I can just do SigninManager* mgr =
SigninManagerFactory::GetForProfile(profile) and leave out the extra
GetInstance().

http://codereview.chromium.org/9169096/diff/1/chrome/browser/chromeos/login/l...
File chrome/browser/chromeos/login/login_utils.cc (right):

http://codereview.chromium.org/9169096/diff/1/chrome/browser/chromeos/login/l...
chrome/browser/chromeos/login/login_utils.cc:915:
ProfileSyncServiceFactory::GetInstance()->GetForProfile(user_profile);
Does this compile? I don't see a closing paren for the ( on the previous line?

http://codereview.chromium.org/9169096/diff/1/chrome/browser/ui/toolbar/wrenc...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

http://codereview.chromium.org/9169096/diff/1/chrome/browser/ui/toolbar/wrenc...
chrome/browser/ui/toolbar/wrench_menu_model.cc:598: return
sync_ui_util::GetSyncMenuLabel(ProfileSyncServiceFactory::
nit: I don't like wrapping after ::, but if there's no better way to do it, it's
fine I guess.

http://codereview.chromium.org/9169096/diff/1/chrome/browser/ui/webui/ntp/for...
File chrome/browser/ui/webui/ntp/foreign_session_handler.cc (right):

http://codereview.chromium.org/9169096/diff/1/chrome/browser/ui/webui/ntp/for...
chrome/browser/ui/webui/ntp/foreign_session_handler.cc:78: ProfileSyncService*
service(ProfileSyncServiceFactory::
nit: also fine, although this combines my two pet style peeves: initializing
pointers with () instead of =, and wrapping after a namespace/style name. Both
perfectly acceptable, of course, I just like whining.

[tim (not reviewing), 2012-01-26 23:55:25]

Fixed compile error and test failure (Drew, you should look at
sync_setup_wizard_unittest again).

[Andrew T Wilson (Slow), 2012-01-27 00:22:40]

LGTM

http://codereview.chromium.org/9169096/diff/6002/chrome/browser/sync/sync_set...
File chrome/browser/sync/sync_setup_wizard_unittest.cc (right):

http://codereview.chromium.org/9169096/diff/6002/chrome/browser/sync/sync_set...
chrome/browser/sync/sync_setup_wizard_unittest.cc:617:
f->GetForProfile(profile)->signin()->SetAuthenticatedUsername(kTestUser);
BTW, you could glom this into one huge ugly statement using
SetTestingFactoryAndUse()...but it's probably better as-is.

[asargent_no_longer_on_chrome, 2012-01-27 00:49:19]

chrome/browser/extensions/* LGTM

http://codereview.chromium.org/9169096/diff/6002/chrome/browser/extensions/ap...
File chrome/browser/extensions/app_notify_channel_ui.cc (right):

http://codereview.chromium.org/9169096/diff/6002/chrome/browser/extensions/ap...
chrome/browser/extensions/app_notify_channel_ui.cc:128: // TODO(REVIEWERS): Why
does this not use OriginalProfile but above we do?
This (and all the others below) can use OriginalProfile

[commit-bot: I haz the power, 2012-01-27 01:25:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/9169096/8001

[commit-bot: I haz the power, 2012-01-27 01:25:50]

Presubmit check for 9169096-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.cc,chrome/browser/ui/webui/options2/options_sync_setup_handler2.cc,chrome/browser/profiles/profile_manager.cc,chrome/browser/ui/webui/options2/stop_syncing_handler2.cc,chrome/browser/ui/webui/options/options_sync_setup_handler.cc,chrome/browser/ui/webui/ntp/ntp_resource_cache.cc,chrome/browser/ui/webui/options2/browser_options_handler2.cc,chrome/browser/ui/webui/ntp/foreign_session_handler.cc,chrome/browser/ui/webui/ntp/ntp_login_handler.cc,chrome/browser/ui/webui/options/stop_syncing_handler.cc,chrome/browser/ui/webui/options/personal_options_handler.cc,chrome/browser/ui/webui/sessions_ui.cc

Presubmit checks took 3.3s to calculate.

[commit-bot: I haz the power, 2012-01-27 01:39:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/9169096/8001

[tim (not reviewing), 2012-01-27 01:42:04]

On 2012/01/27 01:39:18, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/tim%40chromium.org/9169096/8001

+isherman,nkostylev as FYI/TBR

[commit-bot: I haz the power, 2012-01-27 06:03:05]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[Dan Beam, 2012-01-27 07:45:33]

you're gonna have to TBR estade or rbyers for New Tab Page specific changes,
btw...

[commit-bot: I haz the power, 2012-01-27 17:50:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tim@chromium.org/9169096/8001

[commit-bot: I haz the power, 2012-01-27 20:09:16]

Change committed as 119482