Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 9169079: MIPS: Reverted the number of deopt entries to 4096. (Closed)

Created:
8 years, 11 months ago by kalmard
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Reverted the number of deopt entries to 4096. On MIPS we cannot double the number of deoptimization entries easily because the generated code would contain long branches (>128K) and we use BlockTrampolinePoolScope in the Deoptimizer::TableEntryGenerator::GeneratePrologue method. Also, we cannot use the Jr instruction here because the Deoptimizer::CreateCode method asserts that the generated code does not contain reloc information. BUG= TEST= Patch from Daniel Kalmar. Committed: http://code.google.com/p/v8/source/detail?r=10514

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/deoptimizer.h View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kalmard
We noticed that you changed the deoptimization table size to 8k. Unfortunately this change causes ...
8 years, 11 months ago (2012-01-26 11:14:27 UTC) #1
Sven Panne
The reason for this change was that Mandreel-generated JavaScript leads to a huge number of ...
8 years, 11 months ago (2012-01-26 11:55:02 UTC) #2
fschneider
8 years, 11 months ago (2012-01-26 15:33:40 UTC) #3
lgtm

http://codereview.chromium.org/9169079/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

http://codereview.chromium.org/9169079/diff/1/src/deoptimizer.h#newcode271
src/deoptimizer.h:271: static const int kNumberOfEntries = 4096;
Maybe add a comment to why the size is smaller on MIPS.

Powered by Google App Engine
This is Rietveld 408576698