Tweaks to PPB_VarArrayBuffer in preperation for taking out of Dev.

ppapi/shared_impl/ppb_var_shared.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/ppb_var_shared.h"
 
 #include <limits>
 
 #include "ppapi/c/dev/ppb_var_array_buffer_dev.h"
 #include "ppapi/c/ppb_var.h"
@@ skipping 57 matching lines @@
 };
 
 
 // PPB_VarArrayBuffer_Dev methods ----------------------------------------------
 
 PP_Var CreateArrayBufferVar(uint32_t size_in_bytes) {
   return PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(
       size_in_bytes);
 }
 
-uint32_t ByteLength(PP_Var array) {
+PP_Bool ByteLength(PP_Var array, uint32_t* byte_length) {
   ArrayBufferVar* buffer = ArrayBufferVar::FromPPVar(array);
   if (!buffer)
-    return 0;
-  return buffer->ByteLength();
+    return PP_FALSE;

[bbudge, 2012/01/25 22:19:07]

byte_length is undefined in this case. You might want to zero it, or spec this
in the .idl.

[dmichael (off chromium), 2012/01/25 23:50:11]

Good point. My intent is that byte_length is guaranteed to be unchanged in that
case, so I updated the IDL.

+  *byte_length = buffer->ByteLength();
+  return PP_TRUE;
 }
 
 void* Map(PP_Var array) {
   ArrayBufferVar* buffer = ArrayBufferVar::FromPPVar(array);
   if (!buffer)
     return NULL;
   return buffer->Map();
 }
 
+void Unmap(PP_Var array) {
+  ArrayBufferVar* buffer = ArrayBufferVar::FromPPVar(array);
+  if (buffer)
+    buffer->Unmap();
+}
+
 const PPB_VarArrayBuffer_Dev var_arraybuffer_interface = {
   &CreateArrayBufferVar,
   &ByteLength,
-  &Map
+  &Map,
+  &Unmap
 };
 
 }  // namespace
 
 // static
 const PPB_Var_1_1* PPB_Var_Shared::GetVarInterface1_1() {
   return &var_interface;
 }
 
 // static
 const PPB_Var_1_0* PPB_Var_Shared::GetVarInterface1_0() {
   return &var_interface1_0;
 }
 
 // static
 const PPB_VarArrayBuffer_Dev* PPB_Var_Shared::GetVarArrayBufferInterface() {
  return &var_arraybuffer_interface;
 }
 
 }  // namespace ppapi