Tweaks to PPB_VarArrayBuffer in preperation for taking out of Dev.

ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_var.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "native_client/src/shared/ppapi_proxy/plugin_ppb_var.h"
 
 #include <stdio.h>
 
 #include <string>
 #include <utility>
@@ skipping 81 matching lines @@
   PP_Var var;
   var.type = PP_VARTYPE_ARRAY_BUFFER;
   var.value.as_id = proxy_var->id();
   // Increment the reference count for the return to the caller.
   AddRef(var);
   DebugPrintf("PPB_VarArrayBuffer::Create: as_id=%"NACL_PRId64"\n",
               var.value.as_id);
   return var;
 }
 
-uint32_t ByteLength(PP_Var var) {
+PP_Bool ByteLength(PP_Var var, uint32_t* byte_length) {
   DebugPrintf("PPB_VarArrayBuffer::ByteLength: var=PPB_Var(%s)\n",
               PluginVar::DebugString(var).c_str());
   SharedArrayBufferProxyVar buffer_var = ArrayBufferProxyVar::CastFromProxyVar(
       ProxyVarCache::GetInstance().SharedProxyVarForVar(var));
-  uint32_t len = buffer_var->buffer_length();
-  DebugPrintf("PPB_VarArrayBuffer::ByteLength: length=%"NACL_PRIu32"\n", len);
-  return len;
+  if (buffer_var) {
+    *byte_length = buffer_var->buffer_length();
+    DebugPrintf("PPB_VarArrayBuffer::ByteLength: length=%"NACL_PRIu32"\n",
+                *byte_length);
+    return PP_TRUE;
+  }
+  return PP_FALSE;
 }
 
 void* Map(PP_Var var) {
   DebugPrintf("PPB_VarArrayBuffer::Map: var=PPB_Var(%s)\n",
               PluginVar::DebugString(var).c_str());
   SharedArrayBufferProxyVar buffer_var = ArrayBufferProxyVar::CastFromProxyVar(
       ProxyVarCache::GetInstance().SharedProxyVarForVar(var));
   void* data = buffer_var->buffer();
   DebugPrintf("PPB_VarArrayBuffer::Map: buffer=%p\n", data);
   return data;
 }
 
+void Unmap(PP_Var var) {
+  DebugPrintf("PPB_VarArrayBuffer::Unap: var=PPB_Var(%s)\n",
+              PluginVar::DebugString(var).c_str());
+  // We don't use shared memory, so there's nothing to do.
+}
+
 }  // namespace
 
 const PPB_Var* PluginVar::GetInterface() {
   static const PPB_Var var_interface = {
     AddRef,
     Release,
     VarFromUtf8,
     VarToUtf8
   };
   return &var_interface;
 }
 
 const PPB_Var_1_0* PluginVar::GetInterface1_0() {
   static const PPB_Var_1_0 var_interface = {
     AddRef,
     Release,
     VarFromUtf8_1_0,
     VarToUtf8
   };
   return &var_interface;
 }
 
 const PPB_VarArrayBuffer_Dev* PluginVar::GetArrayBufferInterface() {
   static const PPB_VarArrayBuffer_Dev interface = {
     CreateArrayBuffer,
     ByteLength,
-    Map
+    Map,
+    Unmap
   };
   return &interface;
 }
 
 std::string PluginVar::DebugString(const PP_Var& var) {
   switch (var.type) {
     case PP_VARTYPE_UNDEFINED:
       return "##UNDEFINED##";
     case PP_VARTYPE_NULL:
       return "##NULL##";
@@ skipping 88 matching lines @@
     case PP_VARTYPE_STRING:
       {
         std::string str = DebugString(var);
         DebugPrintf("PP_Var(string: '%*s')",
                     static_cast<uint32_t>(str.size()),
                     str.c_str());
       }
     case PP_VARTYPE_OBJECT:
       DebugPrintf("PP_Var(object: %"NACL_PRIu64")", GetVarId(var));
       break;
+    case PP_VARTYPE_ARRAY_BUFFER:
+      DebugPrintf("PP_Var(object: %"NACL_PRIu64")", GetVarId(var));
+      break;
     case PP_VARTYPE_ARRAY:
     case PP_VARTYPE_DICTIONARY:
-    case PP_VARTYPE_ARRAY_BUFFER:
-      NACL_NOTREACHED();
       break;
   }
 }
 
 }  // namespace ppapi_proxy