mach_port_deallocate() the result of mach_thread_self(), which obtains a port send right.

mach_port_deallocate() the result of mach_thread_self(), which obtains a port send right.

BUG=105513
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117127

[Mark Mentovai, 2012-01-10 18:06:51]

You know what you need? You need a test. It validate your code for you.

[Robert Sesek, 2012-01-10 19:07:19]

On 2012/01/10 18:06:51, Mark Mentovai wrote:
> You know what you need? You need a test. It validate your code for you.

OK. This is really ready for another review now.

[Mark Mentovai, 2012-01-10 19:13:46]

LG. Maybe you can test even more:

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
File base/threading/platform_thread_unittest.cc (right):

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:64: 
Maybe put a check in here too to make sure that PlatformThread::CurrentId works
when called on a user thread multiple times, too.

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:107: }
And maybe put a check somewhere in here to make sure that no two threads wound
up with the same ID.

[Robert Sesek, 2012-01-10 19:17:58]

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
File base/threading/platform_thread_unittest.cc (right):

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:64: 
On 2012/01/10 19:13:46, Mark Mentovai wrote:
> Maybe put a check in here too to make sure that PlatformThread::CurrentId
works
> when called on a user thread multiple times, too.

Done.

http://codereview.chromium.org/9169016/diff/7003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:107: }
On 2012/01/10 19:13:46, Mark Mentovai wrote:
> And maybe put a check somewhere in here to make sure that no two threads wound
> up with the same ID.

Done.

[Mark Mentovai, 2012-01-10 19:24:45]

http://codereview.chromium.org/9169016/diff/1003/base/threading/platform_thre...
File base/threading/platform_thread_unittest.cc (right):

http://codereview.chromium.org/9169016/diff/1003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:112: for (size_t i = 0; i <
arraysize(thread); ++i) {
You can simplify this to |i < n| and then get rid of the conditional on the next
line.

[Robert Sesek, 2012-01-10 19:26:29]

http://codereview.chromium.org/9169016/diff/1003/base/threading/platform_thre...
File base/threading/platform_thread_unittest.cc (right):

http://codereview.chromium.org/9169016/diff/1003/base/threading/platform_thre...
base/threading/platform_thread_unittest.cc:112: for (size_t i = 0; i <
arraysize(thread); ++i) {
On 2012/01/10 19:24:45, Mark Mentovai wrote:
> You can simplify this to |i < n| and then get rid of the conditional on the
next
> line.

Done.

[Mark Mentovai, 2012-01-10 19:26:53]

LGTM

[commit-bot: I haz the power, 2012-01-10 19:27:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/9169016/1007

[commit-bot: I haz the power, 2012-01-10 21:40:26]

Try job failure for 9169016-1007 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...