Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 9168036: Pulling into new nacl toolchains. (Closed)

Created:
8 years, 11 months ago by bradn
Modified:
8 years, 11 months ago
Reviewers:
Roland McGrath
CC:
chromium-reviews
Visibility:
Public.

Description

Disabling use of custom build of nacl toolchains for chromeos as the canned nacl toolchain should now function in the chromeos chroot. BUG=None TEST=trybots R=mcgrathr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117275

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M build/download_nacl_toolchains.py View 1 2 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
8 years, 11 months ago (2012-01-11 04:48:16 UTC) #1
Roland McGrath
The nacl_toolchain_revision ought to match the x86_toolchain_version in the native_client/DEPS for the nacl_revision brought in. ...
8 years, 11 months ago (2012-01-11 17:57:19 UTC) #2
bradn
Fair enough. On Wed, Jan 11, 2012 at 9:57 AM, <mcgrathr@chromium.org> wrote: > The nacl_toolchain_revision ...
8 years, 11 months ago (2012-01-11 18:36:58 UTC) #3
bradn
Ok, David's in. Revised to just take out the chromeos hack. PTAL On Wed, Jan ...
8 years, 11 months ago (2012-01-11 19:59:16 UTC) #4
Roland McGrath
8 years, 11 months ago (2012-01-11 20:13:41 UTC) #5
LGTM with happy chromeos bots

Powered by Google App Engine
This is Rietveld 408576698