Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 9167029: i18n - vary width of NTP nav dots based on 'Most Visited' translation (Closed)

Created:
8 years, 11 months ago by Evan Stade
Modified:
8 years, 11 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

i18n - vary width of NTP nav dots based on 'Most Visited' translation BUG=96889 TEST=Looks good in fr, ko, ja, de, en, ml Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117466

Patch Set 1 #

Patch Set 2 : commentary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M chrome/browser/resources/ntp4/nav_dot.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
8 years, 11 months ago (2012-01-10 23:17:57 UTC) #1
Dan Beam
lgtm (hackity hack hack hack)
8 years, 11 months ago (2012-01-11 00:43:14 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
8 years, 11 months ago (2012-01-11 21:56:59 UTC) #3
Evan Stade
+csilv, valid reviewer
8 years, 11 months ago (2012-01-11 22:08:18 UTC) #4
csilv
lgtm
8 years, 11 months ago (2012-01-12 01:28:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9167029/1001
8 years, 11 months ago (2012-01-12 17:42:57 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-12 19:03:16 UTC) #7
Change committed as 117466

Powered by Google App Engine
This is Rietveld 408576698