Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/resources/chromeos/active_downloads.js

Issue 9167019: Consolidate icon loading on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/resources/downloads.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/active_downloads.js
diff --git a/chrome/browser/resources/chromeos/active_downloads.js b/chrome/browser/resources/chromeos/active_downloads.js
index 3615d59b66724801719f0b25be37b44d9f6b8454..1937c112a88cd43ba8496c2559ab51f28f20bfaa 100644
--- a/chrome/browser/resources/chromeos/active_downloads.js
+++ b/chrome/browser/resources/chromeos/active_downloads.js
@@ -233,10 +233,11 @@ DownloadRow.prototype = {
},
setDangerousIcon_: function(warning) {
+ var escapedPath = encodeURIComponent(this.path).replace(/'/g,'%27');
this.icon.className = warning ? 'iconwarning' : 'icon';
this.icon.style.background = warning ? '' :
- 'url(chrome://fileicon' + escape(this.path) +
- '?iconsize=small) no-repeat';
+ 'url(\'chrome://fileicon/' + escapedPath +
+ '?iconsize=small\') no-repeat';
},
/**
« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/resources/downloads.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698