chrome/browser/resources/chromeos/active_downloads.js - Issue 9167019: Consolidate icon loading on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/active_downloads.js

Issue 9167019: Consolidate icon loading on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add comment. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/chromeos/active_downloads.js

diff --git a/chrome/browser/resources/chromeos/active_downloads.js b/chrome/browser/resources/chromeos/active_downloads.js

index 3615d59b66724801719f0b25be37b44d9f6b8454..1937c112a88cd43ba8496c2559ab51f28f20bfaa 100644

--- a/chrome/browser/resources/chromeos/active_downloads.js

+++ b/chrome/browser/resources/chromeos/active_downloads.js

@@ -233,10 +233,11 @@ DownloadRow.prototype = {

setDangerousIcon_: function(warning) {

+ var escapedPath = encodeURIComponent(this.path).replace(/'/g,'%27');

this.icon.className = warning ? 'iconwarning' : 'icon';

this.icon.style.background = warning ? '' :

- 'url(chrome://fileicon' + escape(this.path) +

- '?iconsize=small) no-repeat';

+ 'url(\'chrome://fileicon/' + escapedPath +

+ '?iconsize=small\') no-repeat';

/**

« no previous file with comments | « chrome/browser/icon_manager_chromeos.cc ('k') | chrome/browser/resources/downloads.js » ('j') | no next file with comments »