Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/ui/webui/fileicon_source_unittest.cc

Issue 9167019: Consolidate icon loading on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/fileicon_source_chromeos.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/memory/ref_counted_memory.h"
6 #include "base/message_loop.h"
7 #include "chrome/browser/icon_manager.h"
8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/ui/webui/fileicon_source.h"
10 #include "chrome/test/base/testing_profile.h"
11 #include "content/test/test_browser_thread.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "testing/gmock/include/gmock/gmock.h"
14
15 using content::BrowserThread;
16
17 namespace {
18
19 class TestFileIconSource : public FileIconSource {
20 public:
21 explicit TestFileIconSource() {}
22
23 MOCK_METHOD3(FetchFileIcon, void(const FilePath& path,
24 IconLoader::IconSize icon_size,
25 int request_id));
26 };
27
28 class FileIconSourceTest : public testing::Test {
29 public:
30 FileIconSourceTest()
31 : loop_(MessageLoop::TYPE_UI),
32 ui_thread_(BrowserThread::UI, MessageLoop::current()),
33 file_thread_(BrowserThread::FILE, MessageLoop::current()) {}
34
35 static TestFileIconSource* CreateFileIconSource() {
36 return new TestFileIconSource();
37 }
38
39 private:
40 MessageLoop loop_;
41 content::TestBrowserThread ui_thread_;
42 content::TestBrowserThread file_thread_;
43 };
44
45 const struct FetchFileIconExpectation {
46 const char* request_path;
47 const FilePath::CharType* unescaped_path;
48 IconLoader::IconSize size;
49 } kBasicExpectations[] = {
50 { "foo?bar", FILE_PATH_LITERAL("foo"), IconLoader::NORMAL },
51 { "foo?iconsize=small", FILE_PATH_LITERAL("foo"), IconLoader::SMALL },
52 { "foo?iconsize=normal", FILE_PATH_LITERAL("foo"), IconLoader::NORMAL },
53 { "foo?iconsize=large", FILE_PATH_LITERAL("foo"), IconLoader::LARGE },
54 { "foo?iconsize=asdf", FILE_PATH_LITERAL("foo"), IconLoader::NORMAL },
55 { "foo?blah=b&iconsize=small", FILE_PATH_LITERAL("foo"), IconLoader::SMALL },
56 { "foo?blah&iconsize=small", FILE_PATH_LITERAL("foo"), IconLoader::SMALL },
57 { "a%3Fb%26c%3Dd.txt?iconsize=small", FILE_PATH_LITERAL("a?b&c=d.txt"),
58 IconLoader::SMALL },
59 { "a%3Ficonsize%3Dsmall?iconsize=large",
60 FILE_PATH_LITERAL("a?iconsize=small"), IconLoader::LARGE },
61 { "o%40%23%24%25%26*()%20%2B%3D%3F%2C%3A%3B%22.jpg",
62 FILE_PATH_LITERAL("o@#$%&*() +=?,:;\".jpg"), IconLoader::NORMAL },
63 #if defined(OS_WIN)
64 { "c:/foo/bar/baz", FILE_PATH_LITERAL("c:\\foo\\bar\\baz"),
65 IconLoader::NORMAL },
66 { "/foo?bar=asdf&asdf", FILE_PATH_LITERAL("\\foo"), IconLoader::NORMAL },
67 { "c%3A%2Fusers%2Ffoo%20user%2Fbar.txt",
68 FILE_PATH_LITERAL("c:\\users\\foo user\\bar.txt"), IconLoader::NORMAL },
69 { "c%3A%2Fusers%2F%C2%A9%202000.pdf",
70 FILE_PATH_LITERAL("c:\\users\\\xa9 2000.pdf"), IconLoader::NORMAL },
71 { "%E0%B6%9A%E0%B6%BB%E0%B7%9D%E0%B6%B8%E0%B7%8A",
72 FILE_PATH_LITERAL("\x0d9a\x0dbb\x0ddd\x0db8\x0dca"), IconLoader::NORMAL },
73 { "%2Ffoo%2Fbar", FILE_PATH_LITERAL("\\foo\\bar"), IconLoader::NORMAL },
74 { "%2Fbaz%20(1).txt?iconsize=small", FILE_PATH_LITERAL("\\baz (1).txt"),
75 IconLoader::SMALL },
76 #else
77 { "/foo/bar/baz", FILE_PATH_LITERAL("/foo/bar/baz"), IconLoader::NORMAL },
78 { "/foo?bar", FILE_PATH_LITERAL("/foo"), IconLoader::NORMAL },
79 { "%2Ffoo%2f%E0%B6%9A%E0%B6%BB%E0%B7%9D%E0%B6%B8%E0%B7%8A",
80 FILE_PATH_LITERAL("/foo/\xe0\xb6\x9a\xe0\xb6\xbb\xe0\xb7\x9d")
81 FILE_PATH_LITERAL("\xe0\xb6\xb8\xe0\xb7\x8a"), IconLoader::NORMAL },
82 { "%2Ffoo%2Fbar", FILE_PATH_LITERAL("/foo/bar"), IconLoader::NORMAL },
83 { "%2Fbaz%20(1).txt?iconsize=small", FILE_PATH_LITERAL("/baz (1).txt"),
84 IconLoader::SMALL },
85 #endif
86 };
87
88 } // namespace
89
90 TEST_F(FileIconSourceTest, FileIconSource_Parse) {
91 for (unsigned i = 0; i < arraysize(kBasicExpectations); i++) {
92 scoped_refptr<TestFileIconSource> source(CreateFileIconSource());
93 EXPECT_CALL(*source.get(),
94 FetchFileIcon(FilePath(kBasicExpectations[i].unescaped_path),
95 kBasicExpectations[i].size, i));
96 source->StartDataRequest(kBasicExpectations[i].request_path, false, i);
97 }
98 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/fileicon_source_chromeos.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698