Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(124)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/icon_manager_chromeos.cc
Issue
9167019
:
Consolidate icon loading on ChromeOS (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment.
Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/download/download_extension_test.cc
chrome/browser/icon_loader_chromeos.cc
chrome/browser/icon_manager_chromeos.cc
chrome/browser/resources/chromeos/active_downloads.js
chrome/browser/resources/downloads.js
chrome/browser/ui/webui/active_downloads_ui.cc
chrome/browser/ui/webui/downloads_dom_handler.cc
chrome/browser/ui/webui/fileicon_source.h
chrome/browser/ui/webui/fileicon_source.cc
chrome/browser/ui/webui/fileicon_source_chromeos.h
chrome/browser/ui/webui/fileicon_source_chromeos.cc
chrome/browser/ui/webui/fileicon_source_unittest.cc
chrome/chrome_browser.gypi
chrome/chrome_tests.gypi
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« chrome/browser/icon_loader_chromeos.cc
('k') |
chrome/browser/resources/chromeos/active_downloads.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#include "chrome/browser/icon_manager.h"
6
7
#include "base/file_path.h"
8
#include "base/string_util.h"
9
10
IconGroupID IconManager::GetGroupIDFromFilepath(const FilePath& filepath) {
11
return StringToLowerASCII(filepath.Extension());
12
}
OLD
NEW
« no previous file with comments
|
« chrome/browser/icon_loader_chromeos.cc
('k') |
chrome/browser/resources/chromeos/active_downloads.js »
('j') |
no next file with comments »
Issue 9167019: Consolidate icon loading on ChromeOS (Closed)
Created 8 years, 11 months ago by asanka
Modified 8 years, 10 months ago
Reviewers: achuithb, ilja, Evan Stade
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 15
This is Rietveld
408576698