Consolidate icon loading on ChromeOS

chrome/browser/resources/downloads.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ///////////////////////////////////////////////////////////////////////////////
 // Helper functions
 function $(o) {return document.getElementById(o);}
 
 /**
  * Sets the display style of a node.
@@ skipping 376 matching lines @@
     } else if (this.dangerType_ == Download.DangerType.DANGEROUS_URL) {
       this.dangerDesc_.textContent = localStrings.getString('danger_url_desc');
     } else if (this.dangerType_ == Download.DangerType.DANGEROUS_CONTENT) {
       this.dangerDesc_.textContent = localStrings.getStringF(
           'danger_content_desc', this.fileName_);
     }
     this.danger_.style.display = 'block';
     this.safe_.style.display = 'none';
   } else {
     downloads.scheduleIconLoad(this.nodeImg_,
-                               'chrome://fileicon/' + this.filePath_);
+                               'chrome://fileicon/' +
+                                   encodeURIComponent(this.filePath_));

[achuithb, 2012/01/23 20:59:27]

please make sure this is tested on a chromeos device...

[achuithb, 2012/01/23 21:01:10]

I should've phrased this better - we should make sure this is tested on a
chromeos device before landing it. Do you have a chromeos device handy?

[asanka, 2012/01/26 00:49:35]

Done.

 
     if (this.state_ == Download.States.COMPLETE &&
         !this.fileExternallyRemoved_) {
       this.nodeFileLink_.textContent = this.fileName_;
       this.nodeFileLink_.href = this.fileUrl_;
       this.nodeFileLink_.oncontextmenu = null;
     } else if (this.nodeFileName_.textContent != this.fileName_) {
       this.nodeFileName_.textContent = this.fileName_;
     }
 
@@ skipping 276 matching lines @@
 openDownloadsFolderLink.oncontextmenu = function() { return false; };
 
 $('search-link').onclick = function () {
   setSearch('');
   return false;
 };
 $('search-form').onsubmit = function () {
   setSearch(this.term.value);
   return false;
 };