Issue 9167015: Fix svn delete handling (again).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9167015: Fix svn delete handling (again). (Closed)

Created:
8 years, 11 months ago by M-A Ruel

Modified:
8 years, 11 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix svn delete handling (again). Fix RAW.NEW_NOT_NULL parsing to detect correctly it's a new file. Add proper Hunk parsing to fix these 2 bugs. R=dpranke@chromium.org BUG=109715 TEST=CQ'ing a patch generated with svn that delete files is applied properly, e.g. the file is deleted and not simple 0-length. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117084

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -32 lines)			Patch
M	patch.py	View	4 chunks	+76 lines, -1 line	0 comments	Download
M	testing_support/patches_data.py	View	2 chunks	+99 lines, -0 lines	0 comments	Download
M	tests/patch_test.py	View	6 chunks	+70 lines, -29 lines	0 comments	Download
M	tests/rietveld_test.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9167015/1

8 years, 11 months ago (2012-01-10 19:42:55 UTC) #3

Change committed as 117084

Expand Messages | Collapse Messages