Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 9167011: Support inlining and crankshaft optimization of Math.random. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
1462 LOperand* left = UseFixedDouble(instr->left(), xmm2); 1462 LOperand* left = UseFixedDouble(instr->left(), xmm2);
1463 LOperand* right = exponent_type.IsDouble() ? 1463 LOperand* right = exponent_type.IsDouble() ?
1464 UseFixedDouble(instr->right(), xmm1) : 1464 UseFixedDouble(instr->right(), xmm1) :
1465 UseFixed(instr->right(), eax); 1465 UseFixed(instr->right(), eax);
1466 LPower* result = new(zone()) LPower(left, right); 1466 LPower* result = new(zone()) LPower(left, right);
1467 return MarkAsCall(DefineFixedDouble(result, xmm3), instr, 1467 return MarkAsCall(DefineFixedDouble(result, xmm3), instr,
1468 CAN_DEOPTIMIZE_EAGERLY); 1468 CAN_DEOPTIMIZE_EAGERLY);
1469 } 1469 }
1470 1470
1471 1471
1472 LInstruction* LChunkBuilder::DoRandom(HRandom* instr) {
1473 ASSERT(instr->representation().IsDouble());
1474 ASSERT(instr->global_object()->representation().IsTagged());
1475 LOperand* global_object = UseFixed(instr->global_object(), eax);
1476 LRandom* result = new(zone()) LRandom(global_object);
1477 return MarkAsCall(DefineFixedDouble(result, xmm1),
1478 instr,
1479 CAN_DEOPTIMIZE_EAGERLY);
fschneider 2012/01/11 09:16:28 Since you don't have a DeoptimizeIf in the generat
Mads Ager (chromium) 2012/01/11 10:24:46 Good catch! Thanks Florian. Done.
1480 }
1481
1482
1472 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) { 1483 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) {
1473 ASSERT(instr->left()->representation().IsTagged()); 1484 ASSERT(instr->left()->representation().IsTagged());
1474 ASSERT(instr->right()->representation().IsTagged()); 1485 ASSERT(instr->right()->representation().IsTagged());
1475 LOperand* context = UseFixed(instr->context(), esi); 1486 LOperand* context = UseFixed(instr->context(), esi);
1476 LOperand* left = UseFixed(instr->left(), edx); 1487 LOperand* left = UseFixed(instr->left(), edx);
1477 LOperand* right = UseFixed(instr->right(), eax); 1488 LOperand* right = UseFixed(instr->right(), eax);
1478 LCmpT* result = new(zone()) LCmpT(context, left, right); 1489 LCmpT* result = new(zone()) LCmpT(context, left, right);
1479 return MarkAsCall(DefineFixed(result, eax), instr); 1490 return MarkAsCall(DefineFixed(result, eax), instr);
1480 } 1491 }
1481 1492
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
2388 LOperand* key = UseOrConstantAtStart(instr->key()); 2399 LOperand* key = UseOrConstantAtStart(instr->key());
2389 LOperand* object = UseOrConstantAtStart(instr->object()); 2400 LOperand* object = UseOrConstantAtStart(instr->object());
2390 LIn* result = new(zone()) LIn(context, key, object); 2401 LIn* result = new(zone()) LIn(context, key, object);
2391 return MarkAsCall(DefineFixed(result, eax), instr); 2402 return MarkAsCall(DefineFixed(result, eax), instr);
2392 } 2403 }
2393 2404
2394 2405
2395 } } // namespace v8::internal 2406 } } // namespace v8::internal
2396 2407
2397 #endif // V8_TARGET_ARCH_IA32 2408 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698