Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 9167008: Resolve an ambiguous function call by casting to StringPiece::size_type (Closed)

Created:
8 years, 11 months ago by Peter Beverloo
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org, John Grabowski
Visibility:
Public.

Description

Resolve an ambiguous function call error in string_piece_unittest.cc BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117050

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change the cast to the "U" suffix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/string_piece_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
Since brettw's on leave, and you're back(!), mind having a look Evan? The Android NDK ...
8 years, 11 months ago (2012-01-10 14:16:52 UTC) #1
Peter Beverloo
Working link to the output: http://goo.gl/AnIA5
8 years, 11 months ago (2012-01-10 16:11:36 UTC) #2
Evan Martin
lgtm LGTM with whitespace fixed I admit I don't fully understand what's going on here; ...
8 years, 11 months ago (2012-01-10 16:15:59 UTC) #3
Peter Beverloo
Using "0U" works fine indeed, thank you! I chose "0U" over "0u" to match the ...
8 years, 11 months ago (2012-01-10 16:24:54 UTC) #4
Evan Martin
lgtm
8 years, 11 months ago (2012-01-10 16:55:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/9167008/4001
8 years, 11 months ago (2012-01-10 16:57:10 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-10 18:00:44 UTC) #7
Change committed as 117050

Powered by Google App Engine
This is Rietveld 408576698