Issue 9166014: Allow a Views client to provide a default frameview for window widgets.

Issue 9166014: Allow a Views client to provide a default frameview for window widgets. (Closed)

Created:
8 years, 11 months ago by Ben Goodger (Google)

Modified:
8 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, tfarina, piman+watch_chromium.org, benrg

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Allow a Views client to provide a default frameview for window widgets. Provides a default one in Ash that will be used to match kennedy-spec. Much tweaking is needed, but that can come in future CLs. http://crbug.com/109138 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117165 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117170

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -1 line)			Patch
M	ash/ash.gyp	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/ash_switches.h	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash_switches.cc	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/shell.h	View	1 2 3 4 5 6	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ash/shell.cc	View	1 2 3 4 5 6	2 chunks	+10 lines, -0 lines	0 comments	Download
M	ash/shell/shell_main.cc	View	1 2 3 4 5 6	2 chunks	+16 lines, -1 line	0 comments	Download
A +	ash/wm/dialog_frame_view.h	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ash/wm/dialog_frame_view.cc	View	1 2 3 4 5 6	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	ash/wm/modal_container_layout_manager.cc	View	1 2 3 4 5 6	2 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 2 3 4 5 6	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3 4 5 6	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/accessibility_event_router_views_unittest.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 2 3 4 5 6	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/constrained_window_views.cc	View	1 2 3 4 5 6	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/menu_model_adapter_test.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/test/test_views_delegate.h	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/test/test_views_delegate.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
	ui/views/views_delegate.h	View	1 2 3 4 5 6	2 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 11 months ago (2012-01-10 21:45:30 UTC) #2

LGTM

http://codereview.chromium.org/9166014/diff/3008/ash/ash_switches.h
File ash/ash_switches.h (right):

http://codereview.chromium.org/9166014/diff/3008/ash/ash_switches.h#newcode22
ash/ash_switches.h:22: ASH_EXPORT extern const char kAuraKennedyDialogFrames[];
nit: keep sorted.

http://codereview.chromium.org/9166014/diff/3008/chrome/browser/ui/views/chro...
File chrome/browser/ui/views/chrome_views_delegate.cc (right):

http://codereview.chromium.org/9166014/diff/3008/chrome/browser/ui/views/chro...
chrome/browser/ui/views/chrome_views_delegate.cc:136: }
#else return NULL

Expand Messages | Collapse Messages