Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9166013: Add check for repeated options on test.dart command line. Revert debugging commit r3110. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make error message more descriptive. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index f9878213ea734860798fdfe20a016170f90d4bc6..5a0207a4ec99441794143b234325c3167e8d2745 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -365,12 +365,9 @@ class StandardTestSuite implements TestSuite {
}
}
- // TODO(whesse): Find out if this loop is turning the buildbot red.
- // for (var vmOptions in optionsFromFile['vmOptions']) {
- var vmOptions = optionsFromFile['vmOptions'][0]; {
-
+ for (var vmOptions in optionsFromFile['vmOptions']) {
// Create a unique temporary directory for each set of vmOptions.
- // TODO(whesse): Replace separate replaces with a RegExp when
+ // TODO(dart:429): Replace separate replaceAlls with a RegExp when
// replaceAll(RegExp, String) is implemented.
String optionsName = '';
if (optionsFromFile['vmOptions'].length > 1) {
« no previous file with comments | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698