Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9166013: Add check for repeated options on test.dart command line. Revert debugging commit r3110. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_runner.dart"); 8 #import("test_runner.dart");
9 #import("multitest.dart"); 9 #import("multitest.dart");
10 10
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 if (!testPath.startsWith(dartDir) || 358 if (!testPath.startsWith(dartDir) ||
359 dartDir.endsWith('/frog')) { 359 dartDir.endsWith('/frog')) {
360 dartDir = new File('..').fullPathSync(); 360 dartDir = new File('..').fullPathSync();
361 if (!testPath.startsWith(dartDir)) { 361 if (!testPath.startsWith(dartDir)) {
362 print('Run test.dart from the dart directory or' + 362 print('Run test.dart from the dart directory or' +
363 ' an immediate subdirectory only.'); 363 ' an immediate subdirectory only.');
364 Expect.fail('Could not find top level dart directory.'); 364 Expect.fail('Could not find top level dart directory.');
365 } 365 }
366 } 366 }
367 367
368 // TODO(whesse): Find out if this loop is turning the buildbot red. 368 for (var vmOptions in optionsFromFile['vmOptions']) {
369 // for (var vmOptions in optionsFromFile['vmOptions']) {
370 var vmOptions = optionsFromFile['vmOptions'][0]; {
371
372 // Create a unique temporary directory for each set of vmOptions. 369 // Create a unique temporary directory for each set of vmOptions.
373 // TODO(whesse): Replace separate replaces with a RegExp when 370 // TODO(dart:429): Replace separate replaceAlls with a RegExp when
374 // replaceAll(RegExp, String) is implemented. 371 // replaceAll(RegExp, String) is implemented.
375 String optionsName = ''; 372 String optionsName = '';
376 if (optionsFromFile['vmOptions'].length > 1) { 373 if (optionsFromFile['vmOptions'].length > 1) {
377 optionsName = Strings.join(vmOptions, '-').replaceAll('-','') 374 optionsName = Strings.join(vmOptions, '-').replaceAll('-','')
378 .replaceAll('=','') 375 .replaceAll('=','')
379 .replaceAll('/',''); 376 .replaceAll('/','');
380 } 377 }
381 Directory tempDir = 378 Directory tempDir =
382 createTemporaryDirectory(testPath, dartDir, optionsName); 379 createTemporaryDirectory(testPath, dartDir, optionsName);
383 380
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 * $noCrash tests are expected to be flaky but not crash 1029 * $noCrash tests are expected to be flaky but not crash
1033 * $pass tests are expected to pass 1030 * $pass tests are expected to pass
1034 * $failOk tests are expected to fail that we won't fix 1031 * $failOk tests are expected to fail that we won't fix
1035 * $fail tests are expected to fail that we should fix 1032 * $fail tests are expected to fail that we should fix
1036 * $crash tests are expected to crash that we should fix 1033 * $crash tests are expected to crash that we should fix
1037 * $timeout tests are allowed to timeout\ 1034 * $timeout tests are allowed to timeout\
1038 """; 1035 """;
1039 print(report); 1036 print(report);
1040 } 1037 }
1041 } 1038 }
OLDNEW
« tools/testing/dart/test_options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698