Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: frog/leg/ssa/builder.dart

Issue 9166010: Implement super calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/ssa/builder.dart
diff --git a/frog/leg/ssa/builder.dart b/frog/leg/ssa/builder.dart
index c82c85bddd83db8a425e7286aefd8902c31e2416..bb9272ee6df5a13316d4fb19123c723cd524fde5 100644
--- a/frog/leg/ssa/builder.dart
+++ b/frog/leg/ssa/builder.dart
@@ -551,6 +551,9 @@ class SsaBuilder implements Visitor {
compiler.unimplemented("Ssa.visitIdentifier.", node: node);
}
stack.add(thisDefinition);
+ } else if (node.isSuper()) {
+ // super should not be visited as an identifier.
+ compiler.internalError("unexpected identifier: super", node: node);
} else {
Element element = elements[node];
compiler.ensure(element !== null);
@@ -989,6 +992,20 @@ class SsaBuilder implements Visitor {
}
}
+ visitSuperSend(Send node) {
+ Element element = elements[node];
+ HStatic target = new HStatic(element);
+ HThis context = thisDefinition;
+ if (context === null) {
+ compiler.unimplemented("Ssa.visitSuperSend without thisDefinition.",
+ node: node);
+ }
+ add(target);
+ var inputs = <HInstruction>[target, context];
+ addVisitedSendArgumentsToList(node.arguments, inputs);
+ push(new HInvokeSuper(inputs));
+ }
+
visitStaticSend(Send node) {
Element element = elements[node];
HStatic target = new HStatic(element);
@@ -1006,6 +1023,8 @@ class SsaBuilder implements Visitor {
generateGetter(node, elements[node]);
} else if (Elements.isClosureSend(node, elements)) {
visitClosureSend(node);
+ } else if (node.isSuperCall) {
+ visitSuperSend(node);
} else {
Element element = elements[node];
if (element === null) {
« frog/leg/resolver.dart ('K') | « frog/leg/resolver.dart ('k') | frog/leg/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698