Implement super calls.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 533 matching lines @@
     compiler.registerInstantiatedClass(globalizedClosureElement);
     push(new HForeignNew(globalizedClosureElement, <HInstruction>[]));
   }
 
   visitIdentifier(Identifier node) {
     if (node.isThis()) {
       if (thisDefinition === null) {
         compiler.unimplemented("Ssa.visitIdentifier.", node: node);
       }
       stack.add(thisDefinition);
+    } else if (node.isSuper()) {
+      // super should not be visited as an identifier.
+      compiler.internalError("unexpected identifier: super", node: node);
     } else {
       Element element = elements[node];
       compiler.ensure(element !== null);
       HInstruction def = definitions[element];
       if (def === null) {
         compiler.unimplemented("Ssa.visitIdentifier.", node: node);
       }
       stack.add(def);
     }
   }
@@ skipping 230 matching lines @@
   }
 
   void generateGetter(Send send, Element element) {
     if (Elements.isStaticOrTopLevelField(element)) {
       push(new HStatic(element));
     } else if (element === null || Elements.isInstanceField(element)) {
       HInstruction receiver;
       if (send.receiver == null) {
         receiver = thisDefinition;
         if (receiver === null) {
-          compiler.unimplemented("Ssa.generateGetter.", node: node);
+          compiler.unimplemented("Ssa.generateGetter.", node: send);
         }
       } else {
         visit(send.receiver);
         receiver = pop();
       }
       SourceString getterName = send.selector.asIdentifier().source;
       Element staticInterceptor = null;
       if (methodInterceptionEnabled) {
         staticInterceptor = interceptors.getStaticGetInterceptor(getterName);
       }
@@ skipping 17 matching lines @@
   }
 
   void generateSetter(SendSet send, Element element, HInstruction value) {
     if (Elements.isStaticOrTopLevelField(element)) {
       add(new HStaticStore(element, value));
       stack.add(value);
     } else if (Elements.isInstanceField(element)) {
       String methodName = compiler.namer.setterName(element.name);
       HInstruction receiver = thisDefinition;
       if (receiver === null) {
-        compiler.unimplemented("Ssa.generateSetter.", node: node);
+        compiler.unimplemented("Ssa.generateSetter.", node: send);
       }
       add(new HInvokeDynamicSetter(element, methodName, receiver, value));
       stack.add(value);
     } else if (element === null) {
       SourceString dartSetterName = send.selector.asIdentifier().source;
       String jsSetterName = compiler.namer.setterName(dartSetterName);
       HInstruction receiver;
       if (send.receiver == null) {
         receiver = thisDefinition;
         if (receiver === null) {
-          compiler.unimplemented("Ssa.generateSetter.", node: node);
+          compiler.unimplemented("Ssa.generateSetter.", node: send);
         }
       } else {
         visit(send.receiver);
         receiver = pop();
       }
       add(new HInvokeDynamicSetter(null, jsSetterName, receiver, value));
       stack.add(value);
     } else {
       stack.add(updateDefinition(send, value));
     }
@@ skipping 86 matching lines @@
       assert(closureTarget !== null);
     }
     var inputs = <HInstruction>[];
     inputs.add(closureTarget);
     addVisitedSendArgumentsToList(node.arguments, inputs);
     String jsMethodName = compiler.namer.closureInvocationName();
     push(new HInvokeDynamicMethod(jsMethodName, inputs));
   }
 
   visitForeignSend(Send node) {
-    switch (node.selector.source.stringValue) {
+    switch (node.selector.asIdentifier().source.stringValue) {
       case "JS":
         Link<Node> link = node.arguments;
         // If the invoke is on foreign code, don't visit the first
         // argument, which is the type, and the second argument,
         // which is the foreign code.
         link = link.tail.tail;
         var inputs = <HInstruction>[];
         addVisitedSendArgumentsToList(link, inputs);
         LiteralString type = node.arguments.head;
         LiteralString literal = node.arguments.tail.head;
@@ skipping 10 matching lines @@
         Expression expression = link.head;
         disableMethodInterception();
         visit(expression);
         enableMethodInterception();
         break;
       default:
         throw "Unknown foreign: ${node.selector}";
     }
   }
 
+  visitSuperSend(Send node) {
+    Element element = elements[node];
+    HStatic target = new HStatic(element);
+    HThis context = thisDefinition;
+    if (context === null) {
+      compiler.unimplemented("Ssa.visitSuperSend without thisDefinition.",
+                             node: node);
+    }
+    add(target);
+    var inputs = <HInstruction>[target, context];
+    addVisitedSendArgumentsToList(node.arguments, inputs);
+    push(new HInvokeSuper(inputs));
+  }
+
   visitStaticSend(Send node) {
     Element element = elements[node];
     HStatic target = new HStatic(element);
     add(target);
     var inputs = <HInstruction>[];
     inputs.add(target);
     addVisitedSendArgumentsToList(node.arguments, inputs);
     push(new HInvokeStatic(inputs));
   }
 
   visitSend(Send node) {
     if (node.selector is Operator) {
       visitOperatorSend(node);
     } else if (node.isPropertyAccess) {
       generateGetter(node, elements[node]);
     } else if (Elements.isClosureSend(node, elements)) {
       visitClosureSend(node);
+    } else if (node.receiver !== null &&
+               node.receiver.asIdentifier() !== null &&
+               node.receiver.asIdentifier().isSuper()) {

[ngeoffray, 2012/01/11 13:00:48]

I think we can add a Send.isSuperCall to the Send class.

[karlklose, 2012/01/11 13:46:12]

Done.

+      visitSuperSend(node);
     } else {
       Element element = elements[node];
       if (element === null) {
         // Example: f() with 'f' unbound.
         // This can only happen inside an instance method.
         visitDynamicSend(node);
       } else if (element.isInstanceMember()) {
         // Example: f() with 'f' bound to instance method.
         visitDynamicSend(node);
       } else if (element.kind === ElementKind.FOREIGN) {
@@ skipping 304 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     compiler.unimplemented('SsaBuilder.visitCatchBlock', node: node);
   }
 
   visitTypedef(Typedef node) {
     compiler.unimplemented('SsaBuilder.visitTypedef', node: node);
   }
 }